Title: [148879] trunk
- Revision
- 148879
- Author
- [email protected]
- Date
- 2013-04-22 07:19:24 -0700 (Mon, 22 Apr 2013)
Log Message
[BlackBerry] Add additional datalist support.
https://bugs.webkit.org/show_bug.cgi?id=114883
Reviewed by Rob Buis.
PR 210083.
Source/WebCore:
Extend support for datalist to include all non-popup input types.
Re-enabling fast/forms/datalist/input-list
Internally Reviewed by Otto Cheung.
* platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::RenderThemeBlackBerry::supportsDataListUI):
Source/WebKit/blackberry:
Properly set state when opening a Date/Time popup and simplify
the logic for showing datalist options.
Internally Reviewed by Otto Cheung.
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::openDatePopup):
(BlackBerry::WebKit::InputHandler::showTextInputTypeSuggestionBox):
LayoutTests:
Fix results for fast/forms/datalist/input-list.
Internally Reviewed by Otto Cheung.
* platform/blackberry/fast/forms/datalist/input-list-expected.txt: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (148878 => 148879)
--- trunk/LayoutTests/ChangeLog 2013-04-22 12:39:24 UTC (rev 148878)
+++ trunk/LayoutTests/ChangeLog 2013-04-22 14:19:24 UTC (rev 148879)
@@ -1,3 +1,18 @@
+2013-04-22 Mike Fenton <[email protected]>
+
+ [BlackBerry] Add additional datalist support.
+ https://bugs.webkit.org/show_bug.cgi?id=114883
+
+ Reviewed by Rob Buis.
+
+ PR 210083.
+
+ Fix results for fast/forms/datalist/input-list.
+
+ Internally Reviewed by Otto Cheung.
+
+ * platform/blackberry/fast/forms/datalist/input-list-expected.txt: Added.
+
2013-04-22 Andrei Bucur <[email protected]>
[CSS Regions] Add tests for lists and counters
Added: trunk/LayoutTests/platform/blackberry/fast/forms/datalist/input-list-expected.txt (0 => 148879)
--- trunk/LayoutTests/platform/blackberry/fast/forms/datalist/input-list-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/blackberry/fast/forms/datalist/input-list-expected.txt 2013-04-22 14:19:24 UTC (rev 148879)
@@ -0,0 +1,35 @@
+Test for the list attribute.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS input.list is null
+PASS input.list is null
+PASS input.list is null
+PASS datalist.className is "former"
+PASS document.getElementById("text").list is document.getElementById("dl1")
+PASS document.getElementById("search").list is document.getElementById("dl1")
+PASS document.getElementById("url").list is document.getElementById("dl1")
+PASS document.getElementById("telephone").list is document.getElementById("dl1")
+PASS document.getElementById("email").list is document.getElementById("dl1")
+FAIL document.getElementById("datetime").list should be [object HTMLDataListElement]. Was null.
+FAIL document.getElementById("date").list should be [object HTMLDataListElement]. Was null.
+FAIL document.getElementById("month").list should be [object HTMLDataListElement]. Was null.
+FAIL document.getElementById("week").list should be [object HTMLDataListElement]. Was null.
+FAIL document.getElementById("time").list should be [object HTMLDataListElement]. Was null.
+FAIL document.getElementById("datetime-local").list should be [object HTMLDataListElement]. Was null.
+PASS document.getElementById("number").list is document.getElementById("dl1")
+PASS document.getElementById("range").list is document.getElementById("dl1")
+FAIL document.getElementById("color").list should be [object HTMLDataListElement]. Was null.
+PASS document.getElementById("hidden").list is null
+PASS document.getElementById("password").list is null
+PASS document.getElementById("checkbox").list is null
+PASS document.getElementById("radio").list is null
+PASS document.getElementById("file").list is null
+PASS document.getElementById("submit").list is null
+PASS document.getElementById("image").list is null
+PASS document.getElementById("reset").list is null
+PASS document.getElementById("button").list is null
+PASS successfullyParsed is true
+
+TEST COMPLETE
Modified: trunk/Source/WebCore/ChangeLog (148878 => 148879)
--- trunk/Source/WebCore/ChangeLog 2013-04-22 12:39:24 UTC (rev 148878)
+++ trunk/Source/WebCore/ChangeLog 2013-04-22 14:19:24 UTC (rev 148879)
@@ -1,3 +1,21 @@
+2013-04-22 Mike Fenton <[email protected]>
+
+ [BlackBerry] Add additional datalist support.
+ https://bugs.webkit.org/show_bug.cgi?id=114883
+
+ Reviewed by Rob Buis.
+
+ PR 210083.
+
+ Extend support for datalist to include all non-popup input types.
+
+ Re-enabling fast/forms/datalist/input-list
+
+ Internally Reviewed by Otto Cheung.
+
+ * platform/blackberry/RenderThemeBlackBerry.cpp:
+ (WebCore::RenderThemeBlackBerry::supportsDataListUI):
+
2013-04-22 Alberto Garcia <[email protected]>
[BlackBerry] Add dummy implementations of DragData::droppedFileSystemId()
Modified: trunk/Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp (148878 => 148879)
--- trunk/Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp 2013-04-22 12:39:24 UTC (rev 148878)
+++ trunk/Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp 2013-04-22 14:19:24 UTC (rev 148879)
@@ -1090,8 +1090,14 @@
bool RenderThemeBlackBerry::supportsDataListUI(const AtomicString& type) const
{
- // TODO: support other input types in the future.
- return type == InputTypeNames::text();
+#if ENABLE(DATALIST_ELEMENT)
+ // We support all non-popup driven types.
+ return type == InputTypeNames::text() || type == InputTypeNames::search() || type == InputTypeNames::url()
+ || type == InputTypeNames::telephone() || type == InputTypeNames::email() || type == InputTypeNames::number()
+ || type == InputTypeNames::range();
+#else
+ return false;
+#endif
}
#if ENABLE(DATALIST_ELEMENT)
Modified: trunk/Source/WebKit/blackberry/ChangeLog (148878 => 148879)
--- trunk/Source/WebKit/blackberry/ChangeLog 2013-04-22 12:39:24 UTC (rev 148878)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2013-04-22 14:19:24 UTC (rev 148879)
@@ -1,3 +1,21 @@
+2013-04-22 Mike Fenton <[email protected]>
+
+ [BlackBerry] Add additional datalist support.
+ https://bugs.webkit.org/show_bug.cgi?id=114883
+
+ Reviewed by Rob Buis.
+
+ PR 210083.
+
+ Properly set state when opening a Date/Time popup and simplify
+ the logic for showing datalist options.
+
+ Internally Reviewed by Otto Cheung.
+
+ * WebKitSupport/InputHandler.cpp:
+ (BlackBerry::WebKit::InputHandler::openDatePopup):
+ (BlackBerry::WebKit::InputHandler::showTextInputTypeSuggestionBox):
+
2013-04-19 Andy Chen <[email protected]>
[BlackBerry] Find-on-page should do the scoping again when highlight policy changed
Modified: trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp (148878 => 148879)
--- trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp 2013-04-22 12:39:24 UTC (rev 148878)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp 2013-04-22 14:19:24 UTC (rev 148879)
@@ -1203,6 +1203,9 @@
if (isActiveTextEdit())
clearCurrentFocusElement();
+ m_currentFocusElement = element;
+ m_currentFocusElementType = TextPopup;
+
switch (type) {
case BlackBerry::Platform::InputTypeDate:
case BlackBerry::Platform::InputTypeTime:
@@ -2611,10 +2614,10 @@
void InputHandler::showTextInputTypeSuggestionBox(bool allowEmptyPrefix)
{
- HTMLInputElement* focusedInputElement = static_cast<HTMLInputElement*>(m_currentFocusElement->toInputElement());
- if (!focusedInputElement || !focusedInputElement->isTextField())
+ if (!isActiveTextEdit())
return;
+ HTMLInputElement* focusedInputElement = static_cast<HTMLInputElement*>(m_currentFocusElement->toInputElement());
if (!focusedInputElement)
return;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
