Title: [148932] trunk/Source/WebCore
- Revision
- 148932
- Author
- [email protected]
- Date
- 2013-04-22 16:42:25 -0700 (Mon, 22 Apr 2013)
Log Message
Address review feedback I forgot to address in r148929
https://bugs.webkit.org/show_bug.cgi?id=114480
* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::willSendRequest): Rework the "what" comment into a more useful "why" comment.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (148931 => 148932)
--- trunk/Source/WebCore/ChangeLog 2013-04-22 23:40:35 UTC (rev 148931)
+++ trunk/Source/WebCore/ChangeLog 2013-04-22 23:42:25 UTC (rev 148932)
@@ -1,3 +1,11 @@
+2013-04-22 Brady Eidson <[email protected]>
+
+ Address review feedback I forgot to address in r148929
+ https://bugs.webkit.org/show_bug.cgi?id=114480
+
+ * loader/SubresourceLoader.cpp:
+ (WebCore::SubresourceLoader::willSendRequest): Rework the "what" comment into a more useful "why" comment.
+
2013-04-22 Benjamin Poulain <[email protected]>
Second Mac debug build fix after r148921
Modified: trunk/Source/WebCore/loader/SubresourceLoader.cpp (148931 => 148932)
--- trunk/Source/WebCore/loader/SubresourceLoader.cpp 2013-04-22 23:40:35 UTC (rev 148931)
+++ trunk/Source/WebCore/loader/SubresourceLoader.cpp 2013-04-22 23:42:25 UTC (rev 148932)
@@ -123,8 +123,10 @@
ASSERT(!newRequest.isNull());
if (!redirectResponse.isNull()) {
- // If this redirect takes us somewhere besides the final response URL of the resource we're revalidating,
- // then make this an unconditional GET request.
+ // CachedResources are keyed off their original request URL.
+ // Requesting the same original URL a second time can redirect to a unique second resource.
+ // Therefore, if a redirect to a different destination URL occurs, we should no longer consider this a revalidation of the first resource.
+ // Doing so would have us reusing the resource from the first request if the second request's revalidation succeeds.
if (newRequest.isConditional() && m_resource->resourceToRevalidate() && newRequest.url() != m_resource->resourceToRevalidate()->response().url()) {
newRequest.makeUnconditional();
memoryCache()->revalidationFailed(m_resource);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
