Title: [148947] trunk
Revision
148947
Author
[email protected]
Date
2013-04-23 00:48:49 -0700 (Tue, 23 Apr 2013)

Log Message

Unreviewed, rolling out r148923.
http://trac.webkit.org/changeset/148923
https://bugs.webkit.org/show_bug.cgi?id=115020

The patch causes multiple failures in CSS, canvas tests
(Requested by zdobersek on #webkit).


Source/WebCore:

* platform/graphics/cairo/PlatformContextCairo.cpp:
(WebCore::PlatformContextCairo::drawSurfaceToContext):

LayoutTests:

* fast/canvas/script-tests/shadow-image.js: Removed.
* fast/canvas/shadow-image-expected.txt: Removed.
* fast/canvas/shadow-image.html: Removed.

Modified Paths

Removed Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (148946 => 148947)


--- trunk/LayoutTests/ChangeLog	2013-04-23 07:01:20 UTC (rev 148946)
+++ trunk/LayoutTests/ChangeLog	2013-04-23 07:48:49 UTC (rev 148947)
@@ -1,3 +1,16 @@
+2013-04-23  Commit Queue  <[email protected]>
+
+        Unreviewed, rolling out r148923.
+        http://trac.webkit.org/changeset/148923
+        https://bugs.webkit.org/show_bug.cgi?id=115020
+
+        The patch causes multiple failures in CSS, canvas tests
+        (Requested by zdobersek on #webkit).
+
+        * fast/canvas/script-tests/shadow-image.js: Removed.
+        * fast/canvas/shadow-image-expected.txt: Removed.
+        * fast/canvas/shadow-image.html: Removed.
+
 2013-04-22  Christophe Dumez  <[email protected]>
 
         Unreviewed EFL gardening.

Deleted: trunk/LayoutTests/fast/canvas/script-tests/shadow-image.js (148946 => 148947)


--- trunk/LayoutTests/fast/canvas/script-tests/shadow-image.js	2013-04-23 07:01:20 UTC (rev 148946)
+++ trunk/LayoutTests/fast/canvas/script-tests/shadow-image.js	2013-04-23 07:48:49 UTC (rev 148947)
@@ -1,48 +0,0 @@
-description("Test to verify the shadow of an image drawn on canvas");
-
-// Create an auxiliary canvas to draw to and create an image from.
-// This is done instead of simply loading an image from the file system
-// because that would throw a SECURITY_ERR DOM Exception.
-var aCanvas = document.createElement('canvas');
-aCanvas.setAttribute('width', '200');
-aCanvas.setAttribute('height', '200');
-var aCtx = aCanvas.getContext('2d');
-
-// Draw a rectangle on the same canvas.
-aCtx.fillStyle = 'rgb(0, 255, 0)';
-aCtx.rect(0, 0, 100, 50);
-aCtx.fill();
-
-// Create the image object to be drawn on the master canvas.
-var img = new Image();
-img._onload_ = draw;
-img.src = ""
-
-function draw()
-{
-var canvas = document.getElementById('myCanvas');
-var ctx = canvas.getContext('2d');
-ctx.shadowOffsetX = 200;
-ctx.shadowOffsetY = 50;
-ctx.fillStyle=ctx.createPattern(img, 'repeat-x');
-ctx.shadowColor = 'rgba(255, 0, 0, 1.0)';
-ctx.fillRect(0, 0, 200, 200);
-
-var imageData = ctx.getImageData(10, 10, 1, 1);
-imgdata = imageData.data;
-shouldBe("imgdata[0]", "0");
-shouldBe("imgdata[1]", "255");
-shouldBe("imgdata[2]", "0");
-
-imageData = ctx.getImageData(290, 60, 1, 1);
-imgdata = imageData.data;
-shouldBe("imgdata[0]", "255");
-shouldBe("imgdata[1]", "0");
-shouldBe("imgdata[2]", "0");
-
-imageData = ctx.getImageData(90, 60, 1, 1);
-imgdata = imageData.data;
-shouldBe("imgdata[0]", "0");
-shouldBe("imgdata[1]", "0");
-shouldBe("imgdata[2]", "0");
-}

Deleted: trunk/LayoutTests/fast/canvas/shadow-image-expected.txt (148946 => 148947)


--- trunk/LayoutTests/fast/canvas/shadow-image-expected.txt	2013-04-23 07:01:20 UTC (rev 148946)
+++ trunk/LayoutTests/fast/canvas/shadow-image-expected.txt	2013-04-23 07:48:49 UTC (rev 148947)
@@ -1,18 +0,0 @@
-Test to verify the shadow of an image drawn on canvas
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS successfullyParsed is true
-
-TEST COMPLETE
-PASS imgdata[0] is 0
-PASS imgdata[1] is 255
-PASS imgdata[2] is 0
-PASS imgdata[0] is 255
-PASS imgdata[1] is 0
-PASS imgdata[2] is 0
-PASS imgdata[0] is 0
-PASS imgdata[1] is 0
-PASS imgdata[2] is 0
-

Deleted: trunk/LayoutTests/fast/canvas/shadow-image.html (148946 => 148947)


--- trunk/LayoutTests/fast/canvas/shadow-image.html	2013-04-23 07:01:20 UTC (rev 148946)
+++ trunk/LayoutTests/fast/canvas/shadow-image.html	2013-04-23 07:48:49 UTC (rev 148947)
@@ -1,11 +0,0 @@
-<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
-<html>
-<head>
-<script src=""
-</head>
-<body>
-<canvas id="myCanvas" width="400" height="400"></canvas>
-<script src=""
-<script src=""
-</body>
-</html>

Modified: trunk/Source/WebCore/ChangeLog (148946 => 148947)


--- trunk/Source/WebCore/ChangeLog	2013-04-23 07:01:20 UTC (rev 148946)
+++ trunk/Source/WebCore/ChangeLog	2013-04-23 07:48:49 UTC (rev 148947)
@@ -1,3 +1,15 @@
+2013-04-23  Commit Queue  <[email protected]>
+
+        Unreviewed, rolling out r148923.
+        http://trac.webkit.org/changeset/148923
+        https://bugs.webkit.org/show_bug.cgi?id=115020
+
+        The patch causes multiple failures in CSS, canvas tests
+        (Requested by zdobersek on #webkit).
+
+        * platform/graphics/cairo/PlatformContextCairo.cpp:
+        (WebCore::PlatformContextCairo::drawSurfaceToContext):
+
 2013-04-22  Noam Rosenthal  <[email protected]>
 
         [EFL] Assertion Failures in Coordinated Graphics after r148433

Modified: trunk/Source/WebCore/platform/graphics/cairo/PlatformContextCairo.cpp (148946 => 148947)


--- trunk/Source/WebCore/platform/graphics/cairo/PlatformContextCairo.cpp	2013-04-23 07:01:20 UTC (rev 148946)
+++ trunk/Source/WebCore/platform/graphics/cairo/PlatformContextCairo.cpp	2013-04-23 07:48:49 UTC (rev 148947)
@@ -191,7 +191,7 @@
         cairo_pattern_set_filter(pattern.get(), CAIRO_FILTER_BILINEAR);
         break;
     }
-    cairo_pattern_set_extend(pattern.get(), CAIRO_EXTEND_NONE);
+    cairo_pattern_set_extend(pattern.get(), CAIRO_EXTEND_PAD);
 
     // The pattern transformation properly scales the pattern for when the source rectangle is a
     // different size than the destination rectangle. We also account for any offset we introduced
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to