Title: [148959] trunk/Source/WebKit/blackberry
Revision
148959
Author
[email protected]
Date
2013-04-23 04:58:19 -0700 (Tue, 23 Apr 2013)

Log Message

[BlackBerry] Need to send out change event for date/color picker
https://bugs.webkit.org/show_bug.cgi?id=114942

Reviewed by Carlos Garcia Campos.

We need to instruct the FormControlElements to send out 'change' event
when the user makes the selection and closes the PagePopup for date/color.

* WebCoreSupport/ColorPickerClient.cpp:
(WebCore::ColorPickerClient::setValueAndClosePopup):
* WebCoreSupport/DatePickerClient.cpp:
(WebCore::DatePickerClient::setValueAndClosePopup):

Modified Paths

Diff

Modified: trunk/Source/WebKit/blackberry/ChangeLog (148958 => 148959)


--- trunk/Source/WebKit/blackberry/ChangeLog	2013-04-23 10:29:38 UTC (rev 148958)
+++ trunk/Source/WebKit/blackberry/ChangeLog	2013-04-23 11:58:19 UTC (rev 148959)
@@ -1,3 +1,18 @@
+2013-04-23  Charles Wei  <[email protected]>
+
+        [BlackBerry] Need to send out change event for date/color picker
+        https://bugs.webkit.org/show_bug.cgi?id=114942
+
+        Reviewed by Carlos Garcia Campos.
+
+        We need to instruct the FormControlElements to send out 'change' event
+        when the user makes the selection and closes the PagePopup for date/color.
+
+        * WebCoreSupport/ColorPickerClient.cpp:
+        (WebCore::ColorPickerClient::setValueAndClosePopup):
+        * WebCoreSupport/DatePickerClient.cpp:
+        (WebCore::DatePickerClient::setValueAndClosePopup):
+
 2013-04-22  Eli Fidler  <[email protected]>
 
         [BlackBerry] Update about:config lists

Modified: trunk/Source/WebKit/blackberry/WebCoreSupport/ColorPickerClient.cpp (148958 => 148959)


--- trunk/Source/WebKit/blackberry/WebCoreSupport/ColorPickerClient.cpp	2013-04-23 10:29:38 UTC (rev 148958)
+++ trunk/Source/WebKit/blackberry/WebCoreSupport/ColorPickerClient.cpp	2013-04-23 11:58:19 UTC (rev 148959)
@@ -95,7 +95,7 @@
 
     static const char* cancelValue = "-1";
     if (value != cancelValue)
-        m_element->setValue(value);
+        m_element->setValue(value, DispatchChangeEvent);
     closePopup();
 }
 

Modified: trunk/Source/WebKit/blackberry/WebCoreSupport/DatePickerClient.cpp (148958 => 148959)


--- trunk/Source/WebKit/blackberry/WebCoreSupport/DatePickerClient.cpp	2013-04-23 10:29:38 UTC (rev 148958)
+++ trunk/Source/WebKit/blackberry/WebCoreSupport/DatePickerClient.cpp	2013-04-23 11:58:19 UTC (rev 148959)
@@ -134,7 +134,7 @@
     m_element->document()->frame()->selection()->setCaretVisible(true);
 
     if (value != "-1")
-        m_element->setValue(value);
+        m_element->setValue(value, DispatchChangeEvent);
     closePopup();
 }
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to