Title: [148971] trunk/Tools
- Revision
- 148971
- Author
- [email protected]
- Date
- 2013-04-23 09:20:02 -0700 (Tue, 23 Apr 2013)
Log Message
[Qt] Fix test_build_check for Qt on Mac after r148075.
https://bugs.webkit.org/show_bug.cgi?id=115038
Reviewed by Csaba Osztrogonác.
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(RunTest.test_build_check):
run-webkit-tests is supposed to fail, if it is run on a different
platform than specified on the command line.
However, Qt allows exactly this for Qt-platforms to allow comparing
of test results of different baselines.
Before r148075 "chromium-linux-x86" was used for testing.
This patch changes the port_name to gtk when running the test on mac.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (148970 => 148971)
--- trunk/Tools/ChangeLog 2013-04-23 16:13:17 UTC (rev 148970)
+++ trunk/Tools/ChangeLog 2013-04-23 16:20:02 UTC (rev 148971)
@@ -1,3 +1,19 @@
+2013-04-23 Zeno Albisser <[email protected]>
+
+ [Qt] Fix test_build_check for Qt on Mac after r148075.
+ https://bugs.webkit.org/show_bug.cgi?id=115038
+
+ Reviewed by Csaba Osztrogonác.
+
+ * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
+ (RunTest.test_build_check):
+ run-webkit-tests is supposed to fail, if it is run on a different
+ platform than specified on the command line.
+ However, Qt allows exactly this for Qt-platforms to allow comparing
+ of test results of different baselines.
+ Before r148075 "chromium-linux-x86" was used for testing.
+ This patch changes the port_name to gtk when running the test on mac.
+
2013-04-23 Xan Lopez <[email protected]>
[BlackBerry] Do not access BackForwardListImpl from DRT
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py (148970 => 148971)
--- trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py 2013-04-23 16:13:17 UTC (rev 148970)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py 2013-04-23 16:20:02 UTC (rev 148971)
@@ -820,7 +820,7 @@
def test_build_check(self):
# By using a port_name for a different platform than the one we're running on, the build check should always fail.
if sys.platform == 'darwin':
- port_name = 'qt-linux'
+ port_name = 'gtk'
else:
port_name = 'mac-lion'
out = StringIO.StringIO()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
