Title: [148978] trunk/Source/WebKit/blackberry
Revision
148978
Author
[email protected]
Date
2013-04-23 12:12:31 -0700 (Tue, 23 Apr 2013)

Log Message

[BlackBerry] Invalid assert in InputHandler::requestCheckingOfString()
https://bugs.webkit.org/show_bug.cgi?id=114952

Patch by Carlos Garcia Campos <[email protected]> on 2013-04-23
Reviewed by Rob Buis.

Do not assume that Batch requests are only created whe input field
is focused, the Editor can also create Batch requests when pasting
a selection.

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::requestCheckingOfString):
Remove invalid assert.

Modified Paths

Diff

Modified: trunk/Source/WebKit/blackberry/ChangeLog (148977 => 148978)


--- trunk/Source/WebKit/blackberry/ChangeLog	2013-04-23 19:09:38 UTC (rev 148977)
+++ trunk/Source/WebKit/blackberry/ChangeLog	2013-04-23 19:12:31 UTC (rev 148978)
@@ -1,3 +1,18 @@
+2013-04-23  Carlos Garcia Campos  <[email protected]>
+
+        [BlackBerry] Invalid assert in InputHandler::requestCheckingOfString()
+        https://bugs.webkit.org/show_bug.cgi?id=114952
+
+        Reviewed by Rob Buis.
+
+        Do not assume that Batch requests are only created whe input field
+        is focused, the Editor can also create Batch requests when pasting
+        a selection.
+
+        * WebKitSupport/InputHandler.cpp:
+        (BlackBerry::WebKit::InputHandler::requestCheckingOfString):
+        Remove invalid assert.
+
 2013-04-23  Xan Lopez  <[email protected]>
 
         [BlackBerry] Simplify BackForwardListBlackBerry::clear

Modified: trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp (148977 => 148978)


--- trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp	2013-04-23 19:09:38 UTC (rev 148977)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp	2013-04-23 19:12:31 UTC (rev 148978)
@@ -625,9 +625,6 @@
     }
 
     if (requestLength >= MaxSpellCheckingStringLength) {
-        // Batch requests which are generally created by us on focus, should not exceed this limit. Check that this is in fact of Incremental type.
-        ASSERT(spellCheckRequest->data().processType() == TextCheckingProcessIncremental);
-
         // Cancel this request and send it off in newly created chunks.
         spellCheckRequest->didCancel();
         if (m_currentFocusElement->document() && m_currentFocusElement->document()->frame() && m_currentFocusElement->document()->frame()->selection()) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to