Title: [148981] trunk/Source/WTF
- Revision
- 148981
- Author
- [email protected]
- Date
- 2013-04-23 12:28:42 -0700 (Tue, 23 Apr 2013)
Log Message
Remove unused code of RefCounted after chromium removal
https://bugs.webkit.org/show_bug.cgi?id=115009
Patch by Benjamin Poulain <[email protected]> on 2013-04-23
Reviewed by Ryosuke Niwa.
* wtf/RefCounted.h:
(WTF::RefCountedBase::refCount):
(RefCountedBase):
It looks like addressOfCount() is no longer needed.
Also change the type back to unsigned as it make more sense.
Modified Paths
Diff
Modified: trunk/Source/WTF/ChangeLog (148980 => 148981)
--- trunk/Source/WTF/ChangeLog 2013-04-23 19:21:25 UTC (rev 148980)
+++ trunk/Source/WTF/ChangeLog 2013-04-23 19:28:42 UTC (rev 148981)
@@ -1,3 +1,16 @@
+2013-04-23 Benjamin Poulain <[email protected]>
+
+ Remove unused code of RefCounted after chromium removal
+ https://bugs.webkit.org/show_bug.cgi?id=115009
+
+ Reviewed by Ryosuke Niwa.
+
+ * wtf/RefCounted.h:
+ (WTF::RefCountedBase::refCount):
+ (RefCountedBase):
+ It looks like addressOfCount() is no longer needed.
+ Also change the type back to unsigned as it make more sense.
+
2013-04-23 David Kilzer <[email protected]>
RetainPtr.h should compile with -Wshorten-64-to-32
Modified: trunk/Source/WTF/wtf/RefCounted.h (148980 => 148981)
--- trunk/Source/WTF/wtf/RefCounted.h 2013-04-23 19:21:25 UTC (rev 148980)
+++ trunk/Source/WTF/wtf/RefCounted.h 2013-04-23 19:28:42 UTC (rev 148981)
@@ -71,7 +71,7 @@
return m_refCount == 1;
}
- int refCount() const
+ unsigned refCount() const
{
#if CHECK_REF_COUNTED_LIFECYCLE
ASSERT(m_verifier.isSafeToUse());
@@ -111,12 +111,6 @@
#endif
}
- // Helper for generating JIT code. Please do not use for non-JIT purposes.
- const int* addressOfCount() const
- {
- return &m_refCount;
- }
-
protected:
RefCountedBase()
: m_refCount(1)
@@ -144,7 +138,7 @@
ASSERT(!m_adoptionIsRequired);
#endif
- ASSERT(m_refCount > 0);
+ ASSERT(m_refCount);
if (m_refCount == 1) {
#if CHECK_REF_COUNTED_LIFECYCLE
m_deletionHasBegun = true;
@@ -175,7 +169,7 @@
friend void adopted(RefCountedBase*);
#endif
- int m_refCount;
+ unsigned m_refCount;
#if CHECK_REF_COUNTED_LIFECYCLE
bool m_deletionHasBegun;
bool m_adoptionIsRequired;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes