Title: [149006] trunk/Source/WebKit2
- Revision
- 149006
- Author
- [email protected]
- Date
- 2013-04-23 16:44:41 -0700 (Tue, 23 Apr 2013)
Log Message
Turn off tiled drawing in the Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=115064
Reviewed by Tim Horton.
We get little benefit from making the Web Inspector use tiled drawing;
it doesn't scroll the main frame, so doesn't benefit from the ScrollingCoordinator.
Not using tiled drawing also means that we won't make compositing
layers for position: -webkit-sticky, which avoids a number of issues
with compositing layer proliferation in the inspector.
Also turn off accelerated drawing, since that pref will force a single
compositing layer.
* UIProcess/WebInspectorProxy.cpp:
(WebKit::createInspectorPageGroup):
* UIProcess/mac/WebInspectorProxyMac.mm:
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (149005 => 149006)
--- trunk/Source/WebKit2/ChangeLog 2013-04-23 23:35:12 UTC (rev 149005)
+++ trunk/Source/WebKit2/ChangeLog 2013-04-23 23:44:41 UTC (rev 149006)
@@ -1,5 +1,25 @@
2013-04-23 Simon Fraser <[email protected]>
+ Turn off tiled drawing in the Web Inspector
+ https://bugs.webkit.org/show_bug.cgi?id=115064
+
+ Reviewed by Tim Horton.
+
+ We get little benefit from making the Web Inspector use tiled drawing;
+ it doesn't scroll the main frame, so doesn't benefit from the ScrollingCoordinator.
+ Not using tiled drawing also means that we won't make compositing
+ layers for position: -webkit-sticky, which avoids a number of issues
+ with compositing layer proliferation in the inspector.
+
+ Also turn off accelerated drawing, since that pref will force a single
+ compositing layer.
+
+ * UIProcess/WebInspectorProxy.cpp:
+ (WebKit::createInspectorPageGroup):
+ * UIProcess/mac/WebInspectorProxyMac.mm:
+
+2013-04-23 Simon Fraser <[email protected]>
+
When the web page transparency changes, DrawingAreaImpl needs to know about it
https://bugs.webkit.org/show_bug.cgi?id=115062
Modified: trunk/Source/WebKit2/UIProcess/WebInspectorProxy.cpp (149005 => 149006)
--- trunk/Source/WebKit2/UIProcess/WebInspectorProxy.cpp 2013-04-23 23:35:12 UTC (rev 149005)
+++ trunk/Source/WebKit2/UIProcess/WebInspectorProxy.cpp 2013-04-23 23:44:41 UTC (rev 149006)
@@ -67,10 +67,6 @@
pageGroup->preferences()->setLogsPageMessagesToSystemConsoleEnabled(true);
#endif
-#if PLATFORM(MAC) && !PLATFORM(IOS) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 1080
- pageGroup->preferences()->setAcceleratedDrawingEnabled(true);
-#endif
-
pageGroup->preferences()->setApplicationChromeModeEnabled(true);
return pageGroup.release();
Modified: trunk/Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm (149005 => 149006)
--- trunk/Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm 2013-04-23 23:35:12 UTC (rev 149005)
+++ trunk/Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm 2013-04-23 23:44:41 UTC (rev 149006)
@@ -145,15 +145,6 @@
return WKInspectorViewTag;
}
-- (BOOL)_shouldUseTiledDrawingArea
-{
-#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 1080
- return YES;
-#else
- return NO;
-#endif
-}
-
@end
@interface NSWindow (AppKitDetails)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
