Title: [149080] trunk/Source/WebCore
- Revision
- 149080
- Author
- [email protected]
- Date
- 2013-04-24 17:44:13 -0700 (Wed, 24 Apr 2013)
Log Message
Function parameter quotePair can be passed by reference
https://bugs.webkit.org/show_bug.cgi?id=115089
Reviewed by Alexey Proskuryakov.
Minor performance patch.
* rendering/style/QuotesData.cpp:
(WebCore::QuotesData::addPair):
* rendering/style/QuotesData.h:
(QuotesData):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (149079 => 149080)
--- trunk/Source/WebCore/ChangeLog 2013-04-25 00:17:16 UTC (rev 149079)
+++ trunk/Source/WebCore/ChangeLog 2013-04-25 00:44:13 UTC (rev 149080)
@@ -1,3 +1,17 @@
+2013-04-24 Kangil Han <[email protected]>
+
+ Function parameter quotePair can be passed by reference
+ https://bugs.webkit.org/show_bug.cgi?id=115089
+
+ Reviewed by Alexey Proskuryakov.
+
+ Minor performance patch.
+
+ * rendering/style/QuotesData.cpp:
+ (WebCore::QuotesData::addPair):
+ * rendering/style/QuotesData.h:
+ (QuotesData):
+
2013-04-24 Brady Eidson <[email protected]>
Implementors of CachedResource subclasses should be forced to decide if encoded data can be replaced.
Modified: trunk/Source/WebCore/rendering/style/QuotesData.cpp (149079 => 149080)
--- trunk/Source/WebCore/rendering/style/QuotesData.cpp 2013-04-25 00:17:16 UTC (rev 149079)
+++ trunk/Source/WebCore/rendering/style/QuotesData.cpp 2013-04-25 00:44:13 UTC (rev 149080)
@@ -39,7 +39,7 @@
return data;
}
-void QuotesData::addPair(std::pair<String, String> quotePair)
+void QuotesData::addPair(const std::pair<String, String>& quotePair)
{
m_quotePairs.append(quotePair);
}
Modified: trunk/Source/WebCore/rendering/style/QuotesData.h (149079 => 149080)
--- trunk/Source/WebCore/rendering/style/QuotesData.h 2013-04-25 00:17:16 UTC (rev 149079)
+++ trunk/Source/WebCore/rendering/style/QuotesData.h 2013-04-25 00:44:13 UTC (rev 149080)
@@ -38,7 +38,7 @@
// FIXME: this should be an operator==.
static bool equals(const QuotesData*, const QuotesData*);
- void addPair(const std::pair<String, String> quotePair);
+ void addPair(const std::pair<String, String>& quotePair);
const String getOpenQuote(int index) const;
const String getCloseQuote(int index) const;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
