Title: [149115] trunk/Source/WebCore
Revision
149115
Author
[email protected]
Date
2013-04-25 09:32:51 -0700 (Thu, 25 Apr 2013)

Log Message

REGRESSION(r148758): Remove WTFLogAlways call from IconLoader.
https://bugs.webkit.org/show_bug.cgi?id=115182

Reviewed by Dan Bernstein.

The call added in r148758 was apparently a leftover from some debugging
session, and it makes the Interactive/window-resize.html performance
test randomly fail on Qt and EFL due to WTFLogAlways writing to stderr.

* loader/icon/IconLoader.cpp:
(WebCore::IconLoader::notifyFinished):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (149114 => 149115)


--- trunk/Source/WebCore/ChangeLog	2013-04-25 16:18:43 UTC (rev 149114)
+++ trunk/Source/WebCore/ChangeLog	2013-04-25 16:32:51 UTC (rev 149115)
@@ -1,3 +1,17 @@
+2013-04-25  Raphael Kubo da Costa  <[email protected]>
+
+        REGRESSION(r148758): Remove WTFLogAlways call from IconLoader.
+        https://bugs.webkit.org/show_bug.cgi?id=115182
+
+        Reviewed by Dan Bernstein.
+
+        The call added in r148758 was apparently a leftover from some debugging
+        session, and it makes the Interactive/window-resize.html performance
+        test randomly fail on Qt and EFL due to WTFLogAlways writing to stderr.
+
+        * loader/icon/IconLoader.cpp:
+        (WebCore::IconLoader::notifyFinished):
+
 2013-04-25  Christophe Dumez  <[email protected]>
 
         Add support for Web IDL callback interfaces to the bindings generator

Modified: trunk/Source/WebCore/loader/icon/IconLoader.cpp (149114 => 149115)


--- trunk/Source/WebCore/loader/icon/IconLoader.cpp	2013-04-25 16:18:43 UTC (rev 149114)
+++ trunk/Source/WebCore/loader/icon/IconLoader.cpp	2013-04-25 16:32:51 UTC (rev 149115)
@@ -98,7 +98,6 @@
 
     static const char pdfMagicNumber[] = "%PDF";
     static unsigned pdfMagicNumberLength = sizeof(pdfMagicNumber) - 1;
-    WTFLogAlways("%d\n", pdfMagicNumberLength);
     if (data && data->size() >= pdfMagicNumberLength && !memcmp(data->data(), pdfMagicNumber, pdfMagicNumberLength)) {
         LOG(IconDatabase, "IconLoader::finishLoading() - Ignoring icon at %s because it appears to be a PDF", resource->url().string().ascii().data());
         data = ""
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to