Title: [149134] trunk/Source/_javascript_Core
- Revision
- 149134
- Author
- [email protected]
- Date
- 2013-04-25 12:54:53 -0700 (Thu, 25 Apr 2013)
Log Message
JSC: Fix interpreter misbehavior in builds with JIT disabled
https://bugs.webkit.org/show_bug.cgi?id=115190
Patch by Nick Diego Yamane <[email protected]> on 2013-04-25
Reviewed by Oliver Hunt.
Commit http://trac.webkit.org/changeset/147858 modified
some details on how JS stack traces are built. The method
"getLineNumberForCallFrame", renamed in that changeset to
"getBytecodeOffsetForCallFrame" is always returning `0' when
JIT is disabled
How to reproduce:
- Build webkit with JIT disabled
- Open MiniBrowser, for example, with http://google.com
- In a debug build, WebProcess will hit the following ASSERT:
Source/_javascript_Core/bytecode/UnlinkedCodeBlock.cpp:279 ASSERT(low);
* interpreter/Interpreter.cpp:
(JSC::getBytecodeOffsetForCallFrame):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (149133 => 149134)
--- trunk/Source/_javascript_Core/ChangeLog 2013-04-25 19:50:03 UTC (rev 149133)
+++ trunk/Source/_javascript_Core/ChangeLog 2013-04-25 19:54:53 UTC (rev 149134)
@@ -1,3 +1,25 @@
+2013-04-25 Nick Diego Yamane <[email protected]>
+
+ JSC: Fix interpreter misbehavior in builds with JIT disabled
+ https://bugs.webkit.org/show_bug.cgi?id=115190
+
+ Reviewed by Oliver Hunt.
+
+ Commit http://trac.webkit.org/changeset/147858 modified
+ some details on how JS stack traces are built. The method
+ "getLineNumberForCallFrame", renamed in that changeset to
+ "getBytecodeOffsetForCallFrame" is always returning `0' when
+ JIT is disabled
+
+ How to reproduce:
+ - Build webkit with JIT disabled
+ - Open MiniBrowser, for example, with http://google.com
+ - In a debug build, WebProcess will hit the following ASSERT:
+ Source/_javascript_Core/bytecode/UnlinkedCodeBlock.cpp:279 ASSERT(low);
+
+ * interpreter/Interpreter.cpp:
+ (JSC::getBytecodeOffsetForCallFrame):
+
2013-04-25 Oliver Hunt <[email protected]>
Make checkSyntax take a VM instead of an ExecState
Modified: trunk/Source/_javascript_Core/interpreter/Interpreter.cpp (149133 => 149134)
--- trunk/Source/_javascript_Core/interpreter/Interpreter.cpp 2013-04-25 19:50:03 UTC (rev 149133)
+++ trunk/Source/_javascript_Core/interpreter/Interpreter.cpp 2013-04-25 19:54:53 UTC (rev 149134)
@@ -570,15 +570,11 @@
CodeBlock* codeBlock = callFrame->codeBlock();
if (!codeBlock)
return 0;
-#if ENABLE(JIT)
#if ENABLE(DFG_JIT)
if (codeBlock->getJITType() == JITCode::DFGJIT)
return codeBlock->codeOrigin(callFrame->codeOriginIndexForDFG()).bytecodeIndex;
#endif
return callFrame->bytecodeOffsetForNonDFGCode();
-#else
- return 0;
-#endif
}
static CallFrame* getCallerInfo(VM* vm, CallFrame* callFrame, unsigned& bytecodeOffset, CodeBlock*& caller)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
