Title: [149144] trunk/Source/WebCore
Revision
149144
Author
[email protected]
Date
2013-04-25 14:29:45 -0700 (Thu, 25 Apr 2013)

Log Message

Glyphs may fail to render when using SVG font
https://bugs.webkit.org/show_bug.cgi?id=115193

Reviewed by Simon Fraser.

Calling SimpleFontData::applyTransforms() when the font used is
an SVG font makes little sense since Core Text doesn’t know or
understand SVG fonts and would be passed some other, unrelated
platform font.

* platform/graphics/SimpleFontData.h:
(WebCore::SimpleFontData::applyTransforms):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (149143 => 149144)


--- trunk/Source/WebCore/ChangeLog	2013-04-25 21:21:07 UTC (rev 149143)
+++ trunk/Source/WebCore/ChangeLog	2013-04-25 21:29:45 UTC (rev 149144)
@@ -1,3 +1,18 @@
+2013-04-25  Antoine Quint  <[email protected]>
+
+        Glyphs may fail to render when using SVG font
+        https://bugs.webkit.org/show_bug.cgi?id=115193
+
+        Reviewed by Simon Fraser.
+
+        Calling SimpleFontData::applyTransforms() when the font used is
+        an SVG font makes little sense since Core Text doesn’t know or
+        understand SVG fonts and would be passed some other, unrelated
+        platform font.
+
+        * platform/graphics/SimpleFontData.h:
+        (WebCore::SimpleFontData::applyTransforms):
+
 2013-04-25  Jer Noble  <[email protected]>
 
         Media elements shouldn't resume playback when a page is restored from the back/forward cache if the WKView isn't in a window

Modified: trunk/Source/WebCore/platform/graphics/SimpleFontData.h (149143 => 149144)


--- trunk/Source/WebCore/platform/graphics/SimpleFontData.h	2013-04-25 21:21:07 UTC (rev 149143)
+++ trunk/Source/WebCore/platform/graphics/SimpleFontData.h	2013-04-25 21:29:45 UTC (rev 149144)
@@ -199,6 +199,8 @@
 
     bool applyTransforms(GlyphBufferGlyph* glyphs, GlyphBufferAdvance* advances, size_t glyphCount, TypesettingFeatures typesettingFeatures) const
     {
+        if (isSVGFont())
+            return false;
 #if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED > 1080
         wkCTFontTransformOptions options = (typesettingFeatures & Kerning ? wkCTFontTransformApplyPositioning : 0) | (typesettingFeatures & Ligatures ? wkCTFontTransformApplyShaping : 0);
         return wkCTFontTransformGlyphs(m_platformData.ctFont(), glyphs, reinterpret_cast<CGSize*>(advances), glyphCount, options);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to