Title: [149164] trunk/Tools
Revision
149164
Author
[email protected]
Date
2013-04-25 19:30:11 -0700 (Thu, 25 Apr 2013)

Log Message

Remove support for Chromium from api-test
https://bugs.webkit.org/show_bug.cgi?id=115211

Patch by Seokju Kwon <[email protected]> on 2013-04-25
Reviewed by Dirk Pranke.

* Scripts/build-api-tests:
* Scripts/run-api-tests:
(isSupportedPlatform):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (149163 => 149164)


--- trunk/Tools/ChangeLog	2013-04-26 01:38:23 UTC (rev 149163)
+++ trunk/Tools/ChangeLog	2013-04-26 02:30:11 UTC (rev 149164)
@@ -1,5 +1,16 @@
 2013-04-25  Seokju Kwon  <[email protected]>
 
+        Remove support for Chromium from api-test
+        https://bugs.webkit.org/show_bug.cgi?id=115211
+
+        Reviewed by Dirk Pranke.
+
+        * Scripts/build-api-tests:
+        * Scripts/run-api-tests:
+        (isSupportedPlatform):
+
+2013-04-25  Seokju Kwon  <[email protected]>
+
         Get rid of Chromium in build-dumprendertree
         https://bugs.webkit.org/show_bug.cgi?id=115212
 

Modified: trunk/Tools/Scripts/build-api-tests (149163 => 149164)


--- trunk/Tools/Scripts/build-api-tests	2013-04-26 01:38:23 UTC (rev 149163)
+++ trunk/Tools/Scripts/build-api-tests	2013-04-26 02:30:11 UTC (rev 149164)
@@ -66,9 +66,6 @@
 } elsif (isAppleWinWebKit()) {
     chdir "Tools/TestWebKitAPI" or die;
     $result = buildVisualStudioProject("win/TestWebKitAPI.sln", $clean);
-} elsif (isChromium()) {
-    # Chromium build everything in one shot. No need to build anything here.
-    $result = 0;
 } else {
     die "TestWebKitAPI is not supported on this platform.\n";
 }

Modified: trunk/Tools/Scripts/run-api-tests (149163 => 149164)


--- trunk/Tools/Scripts/run-api-tests	2013-04-26 01:38:23 UTC (rev 149163)
+++ trunk/Tools/Scripts/run-api-tests	2013-04-26 02:30:11 UTC (rev 149164)
@@ -65,7 +65,6 @@
   -d|--dump-tests       Dump the names of testcases without running them
   --[no-]build          Build (or do not build) unit tests prior to running (default: $buildDefault)
   --root=               Path to the pre-built root containing TestWebKitAPI
-  --chromium            Run the Chromium port on Mac/Win/Linux
 EOF
 
 GetOptions(
@@ -83,18 +82,6 @@
 
 setConfiguration();
 
-# When running TestWebKitAPI for Chromium on Android, defer to the test runner in
-# Chromium as we can't execute the binary locally.
-if (isChromiumAndroid()) {
-    my @runTestCommand = ('build/android/run_tests.py', '--verbose', '--webkit', '--exit_code', '--out-directory', sourceDir() . '/out', '-s', 'TestWebKitAPI');
-    if (configuration() eq "Release") {
-        push @runTestCommand, '--release';
-    }
-
-    chdir(sourceDir() . '/Source/WebKit/chromium') or die $!;
-    exit exitStatus(system(@runTestCommand));
-}
-
 setConfigurationProductDir(Cwd::abs_path($root)) if (defined($root));
 
 buildTestTool() if $build && !defined($root);
@@ -112,7 +99,7 @@
 
 sub isSupportedPlatform()
 {
-    return isAppleMacWebKit() || isAppleWinWebKit() || isChromium();
+    return isAppleMacWebKit() || isAppleWinWebKit();
 }
 
 sub dumpTestsBySuite(\@)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to