Title: [149240] trunk/Source/_javascript_Core
- Revision
- 149240
- Author
- [email protected]
- Date
- 2013-04-27 11:25:19 -0700 (Sat, 27 Apr 2013)
Log Message
REGRESSION(r149114): cache flush for SH4 arch may flush an extra page.
https://bugs.webkit.org/show_bug.cgi?id=115305
Patch by Julien Brianceau <[email protected]> on 2013-04-27
Reviewed by Andreas Kling.
* assembler/SH4Assembler.h:
(JSC::SH4Assembler::cacheFlush):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (149239 => 149240)
--- trunk/Source/_javascript_Core/ChangeLog 2013-04-27 18:23:37 UTC (rev 149239)
+++ trunk/Source/_javascript_Core/ChangeLog 2013-04-27 18:25:19 UTC (rev 149240)
@@ -1,3 +1,13 @@
+2013-04-27 Julien Brianceau <[email protected]>
+
+ REGRESSION(r149114): cache flush for SH4 arch may flush an extra page.
+ https://bugs.webkit.org/show_bug.cgi?id=115305
+
+ Reviewed by Andreas Kling.
+
+ * assembler/SH4Assembler.h:
+ (JSC::SH4Assembler::cacheFlush):
+
2013-04-26 Geoffrey Garen <[email protected]>
Re-landing <http://trac.webkit.org/changeset/148999>
Modified: trunk/Source/_javascript_Core/assembler/SH4Assembler.h (149239 => 149240)
--- trunk/Source/_javascript_Core/assembler/SH4Assembler.h 2013-04-27 18:23:37 UTC (rev 149239)
+++ trunk/Source/_javascript_Core/assembler/SH4Assembler.h 2013-04-27 18:25:19 UTC (rev 149240)
@@ -1586,7 +1586,7 @@
#if OS(LINUX)
// Flush each page separately, otherwise the whole flush will fail if an uncommited page is in the area.
unsigned currentPage = reinterpret_cast<unsigned>(code) & ~(pageSize() - 1);
- unsigned lastPage = (reinterpret_cast<unsigned>(code) + size) & ~(pageSize() - 1);
+ unsigned lastPage = (reinterpret_cast<unsigned>(code) + size - 1) & ~(pageSize() - 1);
do {
#if defined CACHEFLUSH_D_L2
syscall(__NR_cacheflush, currentPage, pageSize(), CACHEFLUSH_D_WB | CACHEFLUSH_I | CACHEFLUSH_D_L2);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
