Title: [149258] trunk
- Revision
- 149258
- Author
- [email protected]
- Date
- 2013-04-28 05:39:19 -0700 (Sun, 28 Apr 2013)
Log Message
[WKTR] Tests dumping audio data shouldn't dump pixels
https://bugs.webkit.org/show_bug.cgi?id=115270
Reviewed by Benjamin Poulain.
Tools:
Prevent dumping the pixel output when Web Audio tests are dumping output data
as the testing output. Pixel output in these tests has no real meaning and is
as such unnecessary.
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setAudioData):
LayoutTests:
Remove the now-unnecessary pixel baselines for audio tests that were used on the EFL WK2 platform.
* platform/efl-wk2/webaudio/audiobuffersource-expected.png: Removed.
* platform/efl-wk2/webaudio/audiobuffersource-loop-points-expected.png: Removed.
* platform/efl-wk2/webaudio/audiobuffersource-multi-channels-expected.png: Removed.
* platform/efl-wk2/webaudio/audiobuffersource-playbackrate-expected.png: Removed.
* platform/efl-wk2/webaudio/codec-tests/aac/vbr-128kbps-44khz-expected.png: Removed.
* platform/efl-wk2/webaudio/codec-tests/wav/24bit-22khz-resample-expected.png: Removed.
* platform/efl-wk2/webaudio/codec-tests/wav/24bit-44khz-expected.png: Removed.
* platform/efl-wk2/webaudio/gain-expected.png: Removed.
* platform/efl-wk2/webaudio/mixing-expected.png: Removed.
* platform/efl-wk2/webaudio/oscillator-custom-expected.png: Removed.
* platform/efl-wk2/webaudio/oscillator-sawtooth-expected.png: Removed.
* platform/efl-wk2/webaudio/oscillator-sine-expected.png: Removed.
* platform/efl-wk2/webaudio/oscillator-square-expected.png: Removed.
* platform/efl-wk2/webaudio/oscillator-triangle-expected.png: Removed.
* platform/efl-wk2/webaudio/up-mixing-mono-51-expected.png: Removed.
* platform/efl-wk2/webaudio/up-mixing-mono-stereo-expected.png: Removed.
* platform/efl-wk2/webaudio/up-mixing-stereo-51-expected.png: Removed.
Modified Paths
Removed Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (149257 => 149258)
--- trunk/LayoutTests/ChangeLog 2013-04-28 09:38:28 UTC (rev 149257)
+++ trunk/LayoutTests/ChangeLog 2013-04-28 12:39:19 UTC (rev 149258)
@@ -1,3 +1,30 @@
+2013-04-28 Zan Dobersek <[email protected]>
+
+ [WKTR] Tests dumping audio data shouldn't dump pixels
+ https://bugs.webkit.org/show_bug.cgi?id=115270
+
+ Reviewed by Benjamin Poulain.
+
+ Remove the now-unnecessary pixel baselines for audio tests that were used on the EFL WK2 platform.
+
+ * platform/efl-wk2/webaudio/audiobuffersource-expected.png: Removed.
+ * platform/efl-wk2/webaudio/audiobuffersource-loop-points-expected.png: Removed.
+ * platform/efl-wk2/webaudio/audiobuffersource-multi-channels-expected.png: Removed.
+ * platform/efl-wk2/webaudio/audiobuffersource-playbackrate-expected.png: Removed.
+ * platform/efl-wk2/webaudio/codec-tests/aac/vbr-128kbps-44khz-expected.png: Removed.
+ * platform/efl-wk2/webaudio/codec-tests/wav/24bit-22khz-resample-expected.png: Removed.
+ * platform/efl-wk2/webaudio/codec-tests/wav/24bit-44khz-expected.png: Removed.
+ * platform/efl-wk2/webaudio/gain-expected.png: Removed.
+ * platform/efl-wk2/webaudio/mixing-expected.png: Removed.
+ * platform/efl-wk2/webaudio/oscillator-custom-expected.png: Removed.
+ * platform/efl-wk2/webaudio/oscillator-sawtooth-expected.png: Removed.
+ * platform/efl-wk2/webaudio/oscillator-sine-expected.png: Removed.
+ * platform/efl-wk2/webaudio/oscillator-square-expected.png: Removed.
+ * platform/efl-wk2/webaudio/oscillator-triangle-expected.png: Removed.
+ * platform/efl-wk2/webaudio/up-mixing-mono-51-expected.png: Removed.
+ * platform/efl-wk2/webaudio/up-mixing-mono-stereo-expected.png: Removed.
+ * platform/efl-wk2/webaudio/up-mixing-stereo-51-expected.png: Removed.
+
2013-04-27 Ryosuke Niwa <[email protected]>
Pressing mouse button inside a dragstart event causes a crash
Deleted: trunk/LayoutTests/platform/efl-wk2/webaudio/audiobuffersource-expected.png
(Binary files differ)
Deleted: trunk/LayoutTests/platform/efl-wk2/webaudio/audiobuffersource-loop-points-expected.png
(Binary files differ)
Deleted: trunk/LayoutTests/platform/efl-wk2/webaudio/audiobuffersource-multi-channels-expected.png
(Binary files differ)
Deleted: trunk/LayoutTests/platform/efl-wk2/webaudio/audiobuffersource-playbackrate-expected.png
(Binary files differ)
Deleted: trunk/LayoutTests/platform/efl-wk2/webaudio/codec-tests/aac/vbr-128kbps-44khz-expected.png
(Binary files differ)
Deleted: trunk/LayoutTests/platform/efl-wk2/webaudio/codec-tests/wav/24bit-22khz-resample-expected.png
(Binary files differ)
Deleted: trunk/LayoutTests/platform/efl-wk2/webaudio/codec-tests/wav/24bit-44khz-expected.png
(Binary files differ)
Deleted: trunk/LayoutTests/platform/efl-wk2/webaudio/gain-expected.png
(Binary files differ)
Deleted: trunk/LayoutTests/platform/efl-wk2/webaudio/mixing-expected.png
(Binary files differ)
Deleted: trunk/LayoutTests/platform/efl-wk2/webaudio/oscillator-custom-expected.png
(Binary files differ)
Deleted: trunk/LayoutTests/platform/efl-wk2/webaudio/oscillator-sawtooth-expected.png
(Binary files differ)
Deleted: trunk/LayoutTests/platform/efl-wk2/webaudio/oscillator-sine-expected.png
(Binary files differ)
Deleted: trunk/LayoutTests/platform/efl-wk2/webaudio/oscillator-square-expected.png
(Binary files differ)
Deleted: trunk/LayoutTests/platform/efl-wk2/webaudio/oscillator-triangle-expected.png
(Binary files differ)
Deleted: trunk/LayoutTests/platform/efl-wk2/webaudio/up-mixing-mono-51-expected.png
(Binary files differ)
Deleted: trunk/LayoutTests/platform/efl-wk2/webaudio/up-mixing-mono-stereo-expected.png
(Binary files differ)
Deleted: trunk/LayoutTests/platform/efl-wk2/webaudio/up-mixing-stereo-51-expected.png
(Binary files differ)
Modified: trunk/Tools/ChangeLog (149257 => 149258)
--- trunk/Tools/ChangeLog 2013-04-28 09:38:28 UTC (rev 149257)
+++ trunk/Tools/ChangeLog 2013-04-28 12:39:19 UTC (rev 149258)
@@ -1,3 +1,17 @@
+2013-04-28 Zan Dobersek <[email protected]>
+
+ [WKTR] Tests dumping audio data shouldn't dump pixels
+ https://bugs.webkit.org/show_bug.cgi?id=115270
+
+ Reviewed by Benjamin Poulain.
+
+ Prevent dumping the pixel output when Web Audio tests are dumping output data
+ as the testing output. Pixel output in these tests has no real meaning and is
+ as such unnecessary.
+
+ * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
+ (WTR::TestRunner::setAudioData):
+
2013-04-27 Raphael Kubo da Costa <[email protected]>
[EFL] Unreviewed Intel bots fix after r149231.
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp (149257 => 149258)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp 2013-04-28 09:38:28 UTC (rev 149257)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp 2013-04-28 12:39:19 UTC (rev 149258)
@@ -380,6 +380,7 @@
WKRetainPtr<WKDataRef> audioData(AdoptWK, WKBundleCreateWKDataFromUInt8Array(InjectedBundle::shared().bundle(), context, data));
InjectedBundle::shared().setAudioResult(audioData.get());
m_whatToDump = Audio;
+ m_dumpPixels = false;
}
unsigned TestRunner::windowCount()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
