Diff
Modified: trunk/LayoutTests/ChangeLog (149260 => 149261)
--- trunk/LayoutTests/ChangeLog 2013-04-28 20:31:22 UTC (rev 149260)
+++ trunk/LayoutTests/ChangeLog 2013-04-28 21:52:25 UTC (rev 149261)
@@ -1,3 +1,18 @@
+2013-04-28 Dean Jackson <[email protected]>
+
+ [Mac] Disable canvas backing store scaling (HIGH_DPI_CANVAS)
+ https://bugs.webkit.org/show_bug.cgi?id=115310
+
+ Reviewed by Simon Fraser.
+
+ No need for platform-specific results any more.
+
+ * fast/canvas/2d.backingStorePixelRatio-expected.txt:
+ * fast/canvas/2d.imageDataHD-expected.txt:
+ * fast/canvas/canvas-resize-reset-pixelRatio-expected.txt:
+ * platform/win/fast/canvas/2d.backingStorePixelRatio-expected.txt: Removed.
+ * platform/win/fast/canvas/canvas-resize-reset-pixelRatio-expected.txt: Removed.
+
2013-04-28 Zan Dobersek <[email protected]>
[WKTR] Tests dumping audio data shouldn't dump pixels
Modified: trunk/LayoutTests/fast/canvas/2d.backingStorePixelRatio-expected.txt (149260 => 149261)
--- trunk/LayoutTests/fast/canvas/2d.backingStorePixelRatio-expected.txt 2013-04-28 20:31:22 UTC (rev 149260)
+++ trunk/LayoutTests/fast/canvas/2d.backingStorePixelRatio-expected.txt 2013-04-28 21:52:25 UTC (rev 149261)
@@ -1,3 +1,3 @@
context1.webkitBackingStorePixelRatio is 1
-context2.webkitBackingStorePixelRatio is 2
+context2.webkitBackingStorePixelRatio is 1
Modified: trunk/LayoutTests/fast/canvas/2d.imageDataHD-expected.txt (149260 => 149261)
--- trunk/LayoutTests/fast/canvas/2d.imageDataHD-expected.txt 2013-04-28 20:31:22 UTC (rev 149260)
+++ trunk/LayoutTests/fast/canvas/2d.imageDataHD-expected.txt 2013-04-28 21:52:25 UTC (rev 149261)
@@ -1,12 +1 @@
-Testing getImageDataHD
-PASS: Pixel 0 is green.
-PASS: Pixel 1 is blue.
-
-Testing putImageDataHD
-PASS: Pixel 0 is black.
-PASS: Pixel 0 is green.
-PASS: Pixel 0 is green.
-PASS: Pixel 0 is blue.
-PASS: Pixel 0 is blue.
-PASS: Pixel 0 is black.
-
+High-DPI canvas is not enabled.
Modified: trunk/LayoutTests/fast/canvas/canvas-resize-reset-pixelRatio-expected.txt (149260 => 149261)
--- trunk/LayoutTests/fast/canvas/canvas-resize-reset-pixelRatio-expected.txt 2013-04-28 20:31:22 UTC (rev 149260)
+++ trunk/LayoutTests/fast/canvas/canvas-resize-reset-pixelRatio-expected.txt 2013-04-28 21:52:25 UTC (rev 149261)
@@ -1,6 +1,2 @@
-Testing webkitBackingStorePixelRatio after resize
-PASS: webkitBackingStorePixelRatio is 1.
-PASS: webkitBackingStorePixelRatio is 2.
-PASS: webkitBackingStorePixelRatio is 1.
-PASS: webkitBackingStorePixelRatio is 2.
+High-DPI canvas is not enabled.
Deleted: trunk/LayoutTests/platform/win/fast/canvas/2d.backingStorePixelRatio-expected.txt (149260 => 149261)
--- trunk/LayoutTests/platform/win/fast/canvas/2d.backingStorePixelRatio-expected.txt 2013-04-28 20:31:22 UTC (rev 149260)
+++ trunk/LayoutTests/platform/win/fast/canvas/2d.backingStorePixelRatio-expected.txt 2013-04-28 21:52:25 UTC (rev 149261)
@@ -1,3 +0,0 @@
-context1.webkitBackingStorePixelRatio is 1
-context2.webkitBackingStorePixelRatio is 2
-
Deleted: trunk/LayoutTests/platform/win/fast/canvas/canvas-resize-reset-pixelRatio-expected.txt (149260 => 149261)
--- trunk/LayoutTests/platform/win/fast/canvas/canvas-resize-reset-pixelRatio-expected.txt 2013-04-28 20:31:22 UTC (rev 149260)
+++ trunk/LayoutTests/platform/win/fast/canvas/canvas-resize-reset-pixelRatio-expected.txt 2013-04-28 21:52:25 UTC (rev 149261)
@@ -1,2 +0,0 @@
-High-DPI canvas is not enabled.
-
Modified: trunk/Source/_javascript_Core/ChangeLog (149260 => 149261)
--- trunk/Source/_javascript_Core/ChangeLog 2013-04-28 20:31:22 UTC (rev 149260)
+++ trunk/Source/_javascript_Core/ChangeLog 2013-04-28 21:52:25 UTC (rev 149261)
@@ -1,3 +1,14 @@
+2013-04-28 Dean Jackson <[email protected]>
+
+ [Mac] Disable canvas backing store scaling (HIGH_DPI_CANVAS)
+ https://bugs.webkit.org/show_bug.cgi?id=115310
+
+ Reviewed by Simon Fraser.
+
+ Remove ENABLE_HIGH_DPI_CANVAS_macosx.
+
+ * Configurations/FeatureDefines.xcconfig:
+
2013-04-27 Darin Adler <[email protected]>
Move from constructor and member function adoptCF/NS to free function adoptCF/NS.
Modified: trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig (149260 => 149261)
--- trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig 2013-04-28 20:31:22 UTC (rev 149260)
+++ trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig 2013-04-28 21:52:25 UTC (rev 149261)
@@ -92,7 +92,6 @@
ENABLE_HIDDEN_PAGE_DOM_TIMER_THROTTLING = $(ENABLE_HIDDEN_PAGE_DOM_TIMER_THROTTLING_$(PLATFORM_NAME));
ENABLE_HIDDEN_PAGE_DOM_TIMER_THROTTLING_macosx = ENABLE_HIDDEN_PAGE_DOM_TIMER_THROTTLING;
ENABLE_HIGH_DPI_CANVAS = $(ENABLE_HIGH_DPI_CANVAS_$(PLATFORM_NAME));
-ENABLE_HIGH_DPI_CANVAS_macosx = ENABLE_HIGH_DPI_CANVAS;
ENABLE_ICONDATABASE = $(ENABLE_ICONDATABASE_$(PLATFORM_NAME));
ENABLE_ICONDATABASE_macosx = ENABLE_ICONDATABASE;
ENABLE_IFRAME_SEAMLESS = ENABLE_IFRAME_SEAMLESS;
Modified: trunk/Source/WebCore/ChangeLog (149260 => 149261)
--- trunk/Source/WebCore/ChangeLog 2013-04-28 20:31:22 UTC (rev 149260)
+++ trunk/Source/WebCore/ChangeLog 2013-04-28 21:52:25 UTC (rev 149261)
@@ -1,3 +1,19 @@
+2013-04-28 Dean Jackson <[email protected]>
+
+ [Mac] Disable canvas backing store scaling (HIGH_DPI_CANVAS)
+ https://bugs.webkit.org/show_bug.cgi?id=115310
+
+ Reviewed by Simon Fraser.
+
+ Disable the automatic pixel doubling in canvas backing stores on high
+ dpi devices. This will potentially make canvases look worse of high dpi
+ displays, but only if they were ignoring devicePixelRatio. Since the
+ majority of high dpi displays *do not* auto-double (including mobile
+ devices and other desktop browsers), this provides consistency and less
+ chance of unnecessary memory use.
+
+ * Configurations/FeatureDefines.xcconfig: Remove ENABLE_HIGH_DPI_CANVAS_macosx.
+
2013-04-28 Christophe Dumez <[email protected]>
Get rid of [Callback] IDL extended attribute for parameters
Modified: trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig (149260 => 149261)
--- trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig 2013-04-28 20:31:22 UTC (rev 149260)
+++ trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig 2013-04-28 21:52:25 UTC (rev 149261)
@@ -92,7 +92,6 @@
ENABLE_HIDDEN_PAGE_DOM_TIMER_THROTTLING = $(ENABLE_HIDDEN_PAGE_DOM_TIMER_THROTTLING_$(PLATFORM_NAME));
ENABLE_HIDDEN_PAGE_DOM_TIMER_THROTTLING_macosx = ENABLE_HIDDEN_PAGE_DOM_TIMER_THROTTLING;
ENABLE_HIGH_DPI_CANVAS = $(ENABLE_HIGH_DPI_CANVAS_$(PLATFORM_NAME));
-ENABLE_HIGH_DPI_CANVAS_macosx = ENABLE_HIGH_DPI_CANVAS;
ENABLE_ICONDATABASE = $(ENABLE_ICONDATABASE_$(PLATFORM_NAME));
ENABLE_ICONDATABASE_macosx = ENABLE_ICONDATABASE;
ENABLE_IFRAME_SEAMLESS = ENABLE_IFRAME_SEAMLESS;
Modified: trunk/Source/WebKit/mac/ChangeLog (149260 => 149261)
--- trunk/Source/WebKit/mac/ChangeLog 2013-04-28 20:31:22 UTC (rev 149260)
+++ trunk/Source/WebKit/mac/ChangeLog 2013-04-28 21:52:25 UTC (rev 149261)
@@ -1,3 +1,14 @@
+2013-04-28 Dean Jackson <[email protected]>
+
+ [Mac] Disable canvas backing store scaling (HIGH_DPI_CANVAS)
+ https://bugs.webkit.org/show_bug.cgi?id=115310
+
+ Reviewed by Simon Fraser.
+
+ Remove ENABLE_HIGH_DPI_CANVAS_macosx.
+
+ * Configurations/FeatureDefines.xcconfig:
+
2013-04-27 Darin Adler <[email protected]>
Move from constructor and member function adoptCF/NS to free function adoptCF/NS.
Modified: trunk/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig (149260 => 149261)
--- trunk/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig 2013-04-28 20:31:22 UTC (rev 149260)
+++ trunk/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig 2013-04-28 21:52:25 UTC (rev 149261)
@@ -92,7 +92,6 @@
ENABLE_HIDDEN_PAGE_DOM_TIMER_THROTTLING = $(ENABLE_HIDDEN_PAGE_DOM_TIMER_THROTTLING_$(PLATFORM_NAME));
ENABLE_HIDDEN_PAGE_DOM_TIMER_THROTTLING_macosx = ENABLE_HIDDEN_PAGE_DOM_TIMER_THROTTLING;
ENABLE_HIGH_DPI_CANVAS = $(ENABLE_HIGH_DPI_CANVAS_$(PLATFORM_NAME));
-ENABLE_HIGH_DPI_CANVAS_macosx = ENABLE_HIGH_DPI_CANVAS;
ENABLE_ICONDATABASE = $(ENABLE_ICONDATABASE_$(PLATFORM_NAME));
ENABLE_ICONDATABASE_macosx = ENABLE_ICONDATABASE;
ENABLE_IFRAME_SEAMLESS = ENABLE_IFRAME_SEAMLESS;
Modified: trunk/Source/WebKit2/ChangeLog (149260 => 149261)
--- trunk/Source/WebKit2/ChangeLog 2013-04-28 20:31:22 UTC (rev 149260)
+++ trunk/Source/WebKit2/ChangeLog 2013-04-28 21:52:25 UTC (rev 149261)
@@ -1,3 +1,14 @@
+2013-04-28 Dean Jackson <[email protected]>
+
+ [Mac] Disable canvas backing store scaling (HIGH_DPI_CANVAS)
+ https://bugs.webkit.org/show_bug.cgi?id=115310
+
+ Reviewed by Simon Fraser.
+
+ Remove ENABLE_HIGH_DPI_CANVAS_macosx.
+
+ * Configurations/FeatureDefines.xcconfig:
+
2013-04-28 Sam Weinig <[email protected]>
[WebKit2] Adopt new API for detecting window occlusion
Modified: trunk/Source/WebKit2/Configurations/FeatureDefines.xcconfig (149260 => 149261)
--- trunk/Source/WebKit2/Configurations/FeatureDefines.xcconfig 2013-04-28 20:31:22 UTC (rev 149260)
+++ trunk/Source/WebKit2/Configurations/FeatureDefines.xcconfig 2013-04-28 21:52:25 UTC (rev 149261)
@@ -92,7 +92,6 @@
ENABLE_HIDDEN_PAGE_DOM_TIMER_THROTTLING = $(ENABLE_HIDDEN_PAGE_DOM_TIMER_THROTTLING_$(PLATFORM_NAME));
ENABLE_HIDDEN_PAGE_DOM_TIMER_THROTTLING_macosx = ENABLE_HIDDEN_PAGE_DOM_TIMER_THROTTLING;
ENABLE_HIGH_DPI_CANVAS = $(ENABLE_HIGH_DPI_CANVAS_$(PLATFORM_NAME));
-ENABLE_HIGH_DPI_CANVAS_macosx = ENABLE_HIGH_DPI_CANVAS;
ENABLE_ICONDATABASE = $(ENABLE_ICONDATABASE_$(PLATFORM_NAME));
ENABLE_ICONDATABASE_macosx = ENABLE_ICONDATABASE;
ENABLE_IFRAME_SEAMLESS = ENABLE_IFRAME_SEAMLESS;
