Title: [149304] trunk/Source/_javascript_Core
- Revision
- 149304
- Author
- [email protected]
- Date
- 2013-04-29 12:08:31 -0700 (Mon, 29 Apr 2013)
Log Message
IndexingTypes should use hex
https://bugs.webkit.org/show_bug.cgi?id=115286
Decimal is kind of confusing/hard to read because they're used as bit masks. Hex seems more appropriate.
Reviewed by Geoffrey Garen.
* runtime/IndexingType.h:
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (149303 => 149304)
--- trunk/Source/_javascript_Core/ChangeLog 2013-04-29 19:07:44 UTC (rev 149303)
+++ trunk/Source/_javascript_Core/ChangeLog 2013-04-29 19:08:31 UTC (rev 149304)
@@ -1,3 +1,14 @@
+2013-04-29 Mark Hahnenberg <[email protected]>
+
+ IndexingTypes should use hex
+ https://bugs.webkit.org/show_bug.cgi?id=115286
+
+ Decimal is kind of confusing/hard to read because they're used as bit masks. Hex seems more appropriate.
+
+ Reviewed by Geoffrey Garen.
+
+ * runtime/IndexingType.h:
+
2013-04-29 Carlos Garcia Campos <[email protected]>
Unreviewed. Fix make distcheck.
Modified: trunk/Source/_javascript_Core/runtime/IndexingType.h (149303 => 149304)
--- trunk/Source/_javascript_Core/runtime/IndexingType.h 2013-04-29 19:07:44 UTC (rev 149303)
+++ trunk/Source/_javascript_Core/runtime/IndexingType.h 2013-04-29 19:08:31 UTC (rev 149304)
@@ -34,27 +34,27 @@
typedef uint8_t IndexingType;
// Flags for testing the presence of capabilities.
-static const IndexingType IsArray = 1;
+static const IndexingType IsArray = 0x01;
// The shape of the indexed property storage.
-static const IndexingType IndexingShapeMask = 30;
-static const IndexingType NoIndexingShape = 0;
-static const IndexingType UndecidedShape = 2; // Only useful for arrays.
-static const IndexingType Int32Shape = 20;
-static const IndexingType DoubleShape = 22;
-static const IndexingType ContiguousShape = 26;
-static const IndexingType ArrayStorageShape = 28;
-static const IndexingType SlowPutArrayStorageShape = 30;
+static const IndexingType IndexingShapeMask = 0x1E;
+static const IndexingType NoIndexingShape = 0x00;
+static const IndexingType UndecidedShape = 0x02; // Only useful for arrays.
+static const IndexingType Int32Shape = 0x14;
+static const IndexingType DoubleShape = 0x16;
+static const IndexingType ContiguousShape = 0x1A;
+static const IndexingType ArrayStorageShape = 0x1C;
+static const IndexingType SlowPutArrayStorageShape = 0x1E;
static const IndexingType IndexingShapeShift = 1;
static const IndexingType NumberOfIndexingShapes = 16;
// Additional flags for tracking the history of the type. These are usually
// masked off unless you ask for them directly.
-static const IndexingType MayHaveIndexedAccessors = 32;
+static const IndexingType MayHaveIndexedAccessors = 0x20;
// List of acceptable array types.
-static const IndexingType NonArray = 0;
+static const IndexingType NonArray = 0x0;
static const IndexingType NonArrayWithInt32 = Int32Shape;
static const IndexingType NonArrayWithDouble = DoubleShape;
static const IndexingType NonArrayWithContiguous = ContiguousShape;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
