Title: [149490] trunk/Source/WebKit/blackberry
- Revision
- 149490
- Author
- [email protected]
- Date
- 2013-05-02 11:33:39 -0700 (Thu, 02 May 2013)
Log Message
[BlackBerry] Cannot touch scroll readonly text input.
https://bugs.webkit.org/show_bug.cgi?id=115378
Patch by Genevieve Mak <[email protected]> on 2013-05-02
Reviewed by Rob Buis.
PR #332902
Reviewed Internally by Mike Fenton.
Forgot half the patch.
Node::rendererIsEditable() returns false if the input element has the readonly tag set.
Check the node type instead.
* Api/InRegionScroller.cpp:
(BlackBerry::WebKit::InRegionScrollerPrivate::canScrollRenderBox):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/Api/InRegionScroller.cpp (149489 => 149490)
--- trunk/Source/WebKit/blackberry/Api/InRegionScroller.cpp 2013-05-02 17:45:24 UTC (rev 149489)
+++ trunk/Source/WebKit/blackberry/Api/InRegionScroller.cpp 2013-05-02 18:33:39 UTC (rev 149490)
@@ -20,6 +20,7 @@
#include "InRegionScroller.h"
#include "BackingStoreClient.h"
+#include "DOMSupport.h"
#include "Frame.h"
#include "HTMLFrameOwnerElement.h"
#include "HitTestResult.h"
@@ -456,7 +457,7 @@
return true;
Node* node = box->node();
- return node && (node->rendererIsEditable() || node->isDocumentNode());
+ return node && (DOMSupport::isShadowHostTextInputElement(node) || node->isDocumentNode());
}
static RenderLayer* parentLayer(RenderLayer* layer)
Modified: trunk/Source/WebKit/blackberry/ChangeLog (149489 => 149490)
--- trunk/Source/WebKit/blackberry/ChangeLog 2013-05-02 17:45:24 UTC (rev 149489)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2013-05-02 18:33:39 UTC (rev 149490)
@@ -1,3 +1,19 @@
+2013-05-02 Genevieve Mak <[email protected]>
+
+ [BlackBerry] Cannot touch scroll readonly text input.
+ https://bugs.webkit.org/show_bug.cgi?id=115378
+
+ Reviewed by Rob Buis.
+
+ PR #332902
+ Reviewed Internally by Mike Fenton.
+ Forgot half the patch.
+ Node::rendererIsEditable() returns false if the input element has the readonly tag set.
+ Check the node type instead.
+
+ * Api/InRegionScroller.cpp:
+ (BlackBerry::WebKit::InRegionScrollerPrivate::canScrollRenderBox):
+
2013-05-02 Iris Wu <[email protected]>
[BlackBerry] Make scroll position adjustment work with pages with fixed position elements.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
