Title: [149543] trunk/Source/WebCore
Revision
149543
Author
[email protected]
Date
2013-05-03 16:12:05 -0700 (Fri, 03 May 2013)

Log Message

[GStreamer] GStreamer log crashes in MediaPlayerPrivateGStreamerBase because of uninitialized category
https://bugs.webkit.org/show_bug.cgi?id=115575

Patch by Xabier Rodriguez Calvar <[email protected]> on 2013-05-03
Reviewed by Philippe Normand.

No new tests needed.

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
Using extern debug category.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
Declaring debug category as not static.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (149542 => 149543)


--- trunk/Source/WebCore/ChangeLog	2013-05-03 22:19:15 UTC (rev 149542)
+++ trunk/Source/WebCore/ChangeLog	2013-05-03 23:12:05 UTC (rev 149543)
@@ -1,3 +1,17 @@
+2013-05-03  Xabier Rodriguez Calvar  <[email protected]>
+
+        [GStreamer] GStreamer log crashes in MediaPlayerPrivateGStreamerBase because of uninitialized category
+        https://bugs.webkit.org/show_bug.cgi?id=115575
+
+        Reviewed by Philippe Normand.
+
+        No new tests needed.
+
+        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+        Using extern debug category.
+        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
+        Declaring debug category as not static.
+
 2013-05-03  Brent Fulgham  <[email protected]>
 
         [WinCairo] Unreviewed VS2010 Build Correction.

Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (149542 => 149543)


--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp	2013-05-03 22:19:15 UTC (rev 149542)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp	2013-05-03 23:12:05 UTC (rev 149543)
@@ -76,7 +76,7 @@
 static const gint64 gPercentMax = 100;
 #endif
 
-GST_DEBUG_CATEGORY_STATIC(webkit_media_player_debug);
+GST_DEBUG_CATEGORY_EXTERN(webkit_media_player_debug);
 #define GST_CAT_DEFAULT webkit_media_player_debug
 
 using namespace std;

Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp (149542 => 149543)


--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp	2013-05-03 22:19:15 UTC (rev 149542)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp	2013-05-03 23:12:05 UTC (rev 149543)
@@ -51,7 +51,7 @@
 #include <gst/interfaces/streamvolume.h>
 #endif
 
-GST_DEBUG_CATEGORY_STATIC(webkit_media_player_debug);
+GST_DEBUG_CATEGORY(webkit_media_player_debug);
 #define GST_CAT_DEFAULT webkit_media_player_debug
 
 using namespace std;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to