Title: [149555] trunk/Tools
- Revision
- 149555
- Author
- [email protected]
- Date
- 2013-05-04 00:54:40 -0700 (Sat, 04 May 2013)
Log Message
[GTK] Catch select.error exceptions in parse_output_lines
https://bugs.webkit.org/show_bug.cgi?id=115253
Reviewed by Gustavo Noronha Silva.
Catch any select.error exceptions when waiting for the file descriptor to become readable when parsing the
output lines in common.parse_output_lines. These are currently being thrown when running the GTK unit tests on
builders, but are not fatal. Because of that they are at the moment only logged (writing out the file descriptor,
error code and the error message) and the loop is re-entered.
* gtk/common.py:
(parse_output_lines):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (149554 => 149555)
--- trunk/Tools/ChangeLog 2013-05-04 07:50:19 UTC (rev 149554)
+++ trunk/Tools/ChangeLog 2013-05-04 07:54:40 UTC (rev 149555)
@@ -1,5 +1,20 @@
2013-05-04 Zan Dobersek <[email protected]>
+ [GTK] Catch select.error exceptions in parse_output_lines
+ https://bugs.webkit.org/show_bug.cgi?id=115253
+
+ Reviewed by Gustavo Noronha Silva.
+
+ Catch any select.error exceptions when waiting for the file descriptor to become readable when parsing the
+ output lines in common.parse_output_lines. These are currently being thrown when running the GTK unit tests on
+ builders, but are not fatal. Because of that they are at the moment only logged (writing out the file descriptor,
+ error code and the error message) and the loop is re-entered.
+
+ * gtk/common.py:
+ (parse_output_lines):
+
+2013-05-04 Zan Dobersek <[email protected]>
+
[GTK] Set up the TestWebCore in TestWebKitAPI
https://bugs.webkit.org/show_bug.cgi?id=115237
Modified: trunk/Tools/gtk/common.py (149554 => 149555)
--- trunk/Tools/gtk/common.py 2013-05-04 07:50:19 UTC (rev 149554)
+++ trunk/Tools/gtk/common.py 2013-05-04 07:54:40 UTC (rev 149555)
@@ -114,7 +114,12 @@
output = ''
read_set = [fd]
while read_set:
- rlist, wlist, xlist = select.select(read_set, [], [])
+ try:
+ rlist, wlist, xlist = select.select(read_set, [], [])
+ except select.error as e:
+ parse_line_callback("WARNING: error while waiting for fd %d to become readable\n" % fd)
+ parse_line_callback(" error code: %d, error message: %s\n" % (e[0], e[1]))
+ continue
if fd in rlist:
try:
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
