Title: [149564] branches/dfgFourthTier/Source/_javascript_Core
- Revision
- 149564
- Author
- [email protected]
- Date
- 2013-05-04 12:42:11 -0700 (Sat, 04 May 2013)
Log Message
fourthTier: DFG::ByteCodeParser doesn't need ExecState*
https://bugs.webkit.org/show_bug.cgi?id=115582
Reviewed by Geoffrey Garen.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::ByteCodeParser):
(ByteCodeParser):
(JSC::DFG::parse):
* dfg/DFGByteCodeParser.h:
(DFG):
* dfg/DFGDriver.cpp:
(JSC::DFG::compile):
Modified Paths
Diff
Modified: branches/dfgFourthTier/Source/_javascript_Core/ChangeLog (149563 => 149564)
--- branches/dfgFourthTier/Source/_javascript_Core/ChangeLog 2013-05-04 19:36:34 UTC (rev 149563)
+++ branches/dfgFourthTier/Source/_javascript_Core/ChangeLog 2013-05-04 19:42:11 UTC (rev 149564)
@@ -1,3 +1,19 @@
+2013-05-03 Filip Pizlo <[email protected]>
+
+ fourthTier: DFG::ByteCodeParser doesn't need ExecState*
+ https://bugs.webkit.org/show_bug.cgi?id=115582
+
+ Reviewed by Geoffrey Garen.
+
+ * dfg/DFGByteCodeParser.cpp:
+ (JSC::DFG::ByteCodeParser::ByteCodeParser):
+ (ByteCodeParser):
+ (JSC::DFG::parse):
+ * dfg/DFGByteCodeParser.h:
+ (DFG):
+ * dfg/DFGDriver.cpp:
+ (JSC::DFG::compile):
+
2013-05-03 Geoffrey Garen <[email protected]>
Rolled out r149527 because it caused a crash.
Modified: branches/dfgFourthTier/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp (149563 => 149564)
--- branches/dfgFourthTier/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp 2013-05-04 19:36:34 UTC (rev 149563)
+++ branches/dfgFourthTier/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp 2013-05-04 19:42:11 UTC (rev 149564)
@@ -121,9 +121,8 @@
// This class is used to compile the dataflow graph from a CodeBlock.
class ByteCodeParser {
public:
- ByteCodeParser(ExecState* exec, Graph& graph)
- : m_exec(exec)
- , m_vm(&graph.m_vm)
+ ByteCodeParser(Graph& graph)
+ : m_vm(&graph.m_vm)
, m_codeBlock(graph.m_codeBlock)
, m_profiledBlock(graph.m_profiledBlock)
, m_graph(graph)
@@ -967,7 +966,6 @@
void buildOperandMapsIfNecessary();
- ExecState* m_exec;
VM* m_vm;
CodeBlock* m_codeBlock;
CodeBlock* m_profiledBlock;
@@ -3804,15 +3802,14 @@
return true;
}
-bool parse(ExecState* exec, Graph& graph)
+bool parse(Graph& graph)
{
SamplingRegion samplingRegion("DFG Parsing");
#if DFG_DEBUG_LOCAL_DISBALE
- UNUSED_PARAM(exec);
UNUSED_PARAM(graph);
return false;
#else
- return ByteCodeParser(exec, graph).parse();
+ return ByteCodeParser(graph).parse();
#endif
}
Modified: branches/dfgFourthTier/Source/_javascript_Core/dfg/DFGByteCodeParser.h (149563 => 149564)
--- branches/dfgFourthTier/Source/_javascript_Core/dfg/DFGByteCodeParser.h 2013-05-04 19:36:34 UTC (rev 149563)
+++ branches/dfgFourthTier/Source/_javascript_Core/dfg/DFGByteCodeParser.h 2013-05-04 19:42:11 UTC (rev 149564)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2011 Apple Inc. All rights reserved.
+ * Copyright (C) 2011, 2013 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -39,7 +39,7 @@
// Populate the Graph with a basic block of code from the CodeBlock,
// starting at the provided bytecode index.
-bool parse(ExecState*, Graph&);
+bool parse(Graph&);
} } // namespace JSC::DFG
Modified: branches/dfgFourthTier/Source/_javascript_Core/dfg/DFGDriver.cpp (149563 => 149564)
--- branches/dfgFourthTier/Source/_javascript_Core/dfg/DFGDriver.cpp 2013-05-04 19:36:34 UTC (rev 149563)
+++ branches/dfgFourthTier/Source/_javascript_Core/dfg/DFGDriver.cpp 2013-05-04 19:42:11 UTC (rev 149564)
@@ -123,7 +123,7 @@
}
Graph dfg(exec->vm(), codeBlock, osrEntryBytecodeIndex, mustHandleValues);
- if (!parse(exec, dfg))
+ if (!parse(dfg))
return false;
// By this point the DFG bytecode parser will have potentially mutated various tables
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
