Title: [149625] trunk/Source/WebKit/blackberry
- Revision
- 149625
- Author
- [email protected]
- Date
- 2013-05-06 12:29:52 -0700 (Mon, 06 May 2013)
Log Message
[BlackBerry] Use a more descriptive timer name
https://bugs.webkit.org/show_bug.cgi?id=115481
Patch by Nima Ghanavatian <[email protected]> on 2013-05-06
Reviewed by Rob Buis.
Internally reviewed by Mike Fenton.
Changing m_timer to m_iterationDelayTimer.
* WebKitSupport/SpellingHandler.cpp:
(BlackBerry::WebKit::SpellingHandler::SpellingHandler):
(BlackBerry::WebKit::SpellingHandler::spellCheckTextBlock):
(BlackBerry::WebKit::SpellingHandler::parseBlockForSpellChecking):
* WebKitSupport/SpellingHandler.h:
(SpellingHandler):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/ChangeLog (149624 => 149625)
--- trunk/Source/WebKit/blackberry/ChangeLog 2013-05-06 19:13:30 UTC (rev 149624)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2013-05-06 19:29:52 UTC (rev 149625)
@@ -1,3 +1,21 @@
+2013-05-06 Nima Ghanavatian <[email protected]>
+
+ [BlackBerry] Use a more descriptive timer name
+ https://bugs.webkit.org/show_bug.cgi?id=115481
+
+ Reviewed by Rob Buis.
+
+ Internally reviewed by Mike Fenton.
+
+ Changing m_timer to m_iterationDelayTimer.
+
+ * WebKitSupport/SpellingHandler.cpp:
+ (BlackBerry::WebKit::SpellingHandler::SpellingHandler):
+ (BlackBerry::WebKit::SpellingHandler::spellCheckTextBlock):
+ (BlackBerry::WebKit::SpellingHandler::parseBlockForSpellChecking):
+ * WebKitSupport/SpellingHandler.h:
+ (SpellingHandler):
+
2013-05-04 Nima Ghanavatian <[email protected]>
[BlackBerry] Clean up unused spellcheck code
Modified: trunk/Source/WebKit/blackberry/WebKitSupport/SpellingHandler.cpp (149624 => 149625)
--- trunk/Source/WebKit/blackberry/WebKitSupport/SpellingHandler.cpp 2013-05-06 19:13:30 UTC (rev 149624)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/SpellingHandler.cpp 2013-05-06 19:29:52 UTC (rev 149625)
@@ -32,7 +32,7 @@
SpellingHandler::SpellingHandler(InputHandler* inputHandler)
: m_inputHandler(inputHandler)
- , m_timer(this, &SpellingHandler::parseBlockForSpellChecking)
+ , m_iterationDelayTimer(this, &SpellingHandler::parseBlockForSpellChecking)
, m_isSpellCheckActive(false)
{
}
@@ -57,8 +57,8 @@
// from a previously focused element.
if (m_textCheckingProcessType == TextCheckingProcessBatch) {
// If a previous request is being processed, stop it before continueing.
- if (m_timer.isActive())
- m_timer.stop();
+ if (m_iterationDelayTimer.isActive())
+ m_iterationDelayTimer.stop();
}
m_isSpellCheckActive = true;
@@ -79,7 +79,7 @@
m_endOfRange = visibleSelection.visibleEnd();
m_cachedEndPosition = m_endOfRange;
- m_timer.startOneShot(0);
+ m_iterationDelayTimer.startOneShot(0);
}
void SpellingHandler::createSpellCheckRequest(const PassRefPtr<WebCore::Range> rangeForSpellCheckingPtr)
@@ -122,7 +122,7 @@
}
incrementSentinels(false /* shouldIncrementStartPosition */);
- m_timer.startOneShot(s_timeout);
+ m_iterationDelayTimer.startOneShot(s_timeout);
return;
}
@@ -131,7 +131,7 @@
createSpellCheckRequest(rangeForSpellChecking);
if (isSpellCheckActive())
- m_timer.startOneShot(s_timeout);
+ m_iterationDelayTimer.startOneShot(s_timeout);
}
PassRefPtr<Range> SpellingHandler::handleOversizedRange()
Modified: trunk/Source/WebKit/blackberry/WebKitSupport/SpellingHandler.h (149624 => 149625)
--- trunk/Source/WebKit/blackberry/WebKitSupport/SpellingHandler.h 2013-05-06 19:13:30 UTC (rev 149624)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/SpellingHandler.h 2013-05-06 19:29:52 UTC (rev 149625)
@@ -42,7 +42,7 @@
InputHandler* m_inputHandler;
- WebCore::Timer<SpellingHandler> m_timer;
+ WebCore::Timer<SpellingHandler> m_iterationDelayTimer;
WebCore::VisiblePosition m_startPosition;
WebCore::VisiblePosition m_endPosition;
WebCore::VisiblePosition m_cachedEndPosition;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
