Title: [149660] trunk/Source/WebCore
- Revision
- 149660
- Author
- [email protected]
- Date
- 2013-05-06 21:15:05 -0700 (Mon, 06 May 2013)
Log Message
[Replaceable] attributes must be readonly
https://bugs.webkit.org/show_bug.cgi?id=115692
Reviewed by Kentaro Hara.
Merge https://chromium.googlesource.com/chromium/blink/+/ac61fbfe875d3c3c37d529683139ceb0ad4330bb.
Web IDL specification says [Replaceable] attributes are readonly:
http://www.w3.org/TR/2012/CR-WebIDL-20120419/#Replaceable
Update the two instances of [Replaceable] in WebCore that didn't have readonly modifier to match
the specifcation and the rest of WebCore. There should be no behavioral changes as the code generator
already assumed [Replaceable] attributes are readonly.
* html/HTMLDocument.idl:
* page/DOMWindow.idl:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (149659 => 149660)
--- trunk/Source/WebCore/ChangeLog 2013-05-07 04:05:10 UTC (rev 149659)
+++ trunk/Source/WebCore/ChangeLog 2013-05-07 04:15:05 UTC (rev 149660)
@@ -1,3 +1,22 @@
+2013-05-06 Ryosuke Niwa <[email protected]>
+
+ [Replaceable] attributes must be readonly
+ https://bugs.webkit.org/show_bug.cgi?id=115692
+
+ Reviewed by Kentaro Hara.
+
+ Merge https://chromium.googlesource.com/chromium/blink/+/ac61fbfe875d3c3c37d529683139ceb0ad4330bb.
+
+ Web IDL specification says [Replaceable] attributes are readonly:
+ http://www.w3.org/TR/2012/CR-WebIDL-20120419/#Replaceable
+
+ Update the two instances of [Replaceable] in WebCore that didn't have readonly modifier to match
+ the specifcation and the rest of WebCore. There should be no behavioral changes as the code generator
+ already assumed [Replaceable] attributes are readonly.
+
+ * html/HTMLDocument.idl:
+ * page/DOMWindow.idl:
+
2013-05-06 Darin Adler <[email protected]>
Use OwnPtr instead of deleteAllValues in DocumentMarkerController
Modified: trunk/Source/WebCore/html/HTMLDocument.idl (149659 => 149660)
--- trunk/Source/WebCore/html/HTMLDocument.idl 2013-05-07 04:05:10 UTC (rev 149659)
+++ trunk/Source/WebCore/html/HTMLDocument.idl 2013-05-07 04:15:05 UTC (rev 149660)
@@ -34,7 +34,7 @@
#if defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT
// FIXME: This should eventually be available (if they are wanted) for all languages.
- [Custom, Replaceable, Deletable] attribute HTMLAllCollection all;
+ [Custom, Replaceable, Deletable] readonly attribute HTMLAllCollection all;
#endif
void clear();
Modified: trunk/Source/WebCore/page/DOMWindow.idl (149659 => 149660)
--- trunk/Source/WebCore/page/DOMWindow.idl 2013-05-07 04:05:10 UTC (rev 149659)
+++ trunk/Source/WebCore/page/DOMWindow.idl 2013-05-07 04:15:05 UTC (rev 149660)
@@ -210,7 +210,7 @@
DOMString btoa([TreatNullAs=NullString,Default=Undefined] optional DOMString string)
raises(DOMException);
- attribute [Replaceable,Conditional=CSS3_CONDITIONAL_RULES] DOMWindowCSS CSS;
+ readonly attribute [Replaceable,Conditional=CSS3_CONDITIONAL_RULES] DOMWindowCSS CSS;
// Events
attribute EventListener onabort;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
