Log Message
fixed a memory leak introduced by bug 42324 by using a RetainPtr https://bugs.webkit.org/show_bug.cgi?id=115760
Patch by Alex Christensen <[email protected]> on 2013-05-07 Reviewed by Tim Horton. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::dumpDOMAsWebArchive): fixed memory leak, added UNUSED_PARAM macros
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (149696 => 149697)
--- trunk/Tools/ChangeLog 2013-05-07 22:14:04 UTC (rev 149696)
+++ trunk/Tools/ChangeLog 2013-05-07 22:26:16 UTC (rev 149697)
@@ -1,5 +1,16 @@
2013-05-07 Alex Christensen <[email protected]>
+ fixed a memory leak introduced by bug 42324 by using a RetainPtr
+ https://bugs.webkit.org/show_bug.cgi?id=115760
+
+ Reviewed by Tim Horton.
+
+ * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
+ (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
+ fixed memory leak, added UNUSED_PARAM macros
+
+2013-05-07 Alex Christensen <[email protected]>
+
WebKitTestRunner needs testRunner.dumpDOMAsWebArchive
https://bugs.webkit.org/show_bug.cgi?id=42324
<rdar://problem/8193633>
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp (149696 => 149697)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp 2013-05-07 22:14:04 UTC (rev 149696)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp 2013-05-07 22:26:16 UTC (rev 149697)
@@ -845,10 +845,13 @@
void InjectedBundlePage::dumpDOMAsWebArchive(WKBundleFrameRef frame, StringBuilder& stringBuilder)
{
#if USE(CF)
- WKDataRef wkData = WKBundleFrameCopyWebArchive(frame);
- RetainPtr<CFDataRef> cfData = adoptCF(CFDataCreate(0, WKDataGetBytes(wkData), WKDataGetSize(wkData)));
+ RetainPtr<WKDataRef> wkData = WKBundleFrameCopyWebArchive(frame);
+ RetainPtr<CFDataRef> cfData = adoptCF(CFDataCreate(0, WKDataGetBytes(wkData.get()), WKDataGetSize(wkData.get())));
RetainPtr<CFStringRef> cfString = adoptCF(createXMLStringFromWebArchiveData(cfData.get()));
stringBuilder.append(cfString.get());
+#else
+ UNUSED_PARAM(frame);
+ UNUSED_PARAM(stringBuilder);
#endif
}
_______________________________________________ webkit-changes mailing list [email protected] https://lists.webkit.org/mailman/listinfo/webkit-changes
