Title: [149703] trunk/Tools
- Revision
- 149703
- Author
- [email protected]
- Date
- 2013-05-07 18:26:34 -0700 (Tue, 07 May 2013)
Log Message
[Win] Fix storage leak in Windows DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=115651
Reviewed by Sam Weinig.
* DumpRenderTree/win/DumpRenderTree.cpp:
(lastPathComponent): Added a missing call to adoptCF.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (149702 => 149703)
--- trunk/Tools/ChangeLog 2013-05-08 01:13:34 UTC (rev 149702)
+++ trunk/Tools/ChangeLog 2013-05-08 01:26:34 UTC (rev 149703)
@@ -1,3 +1,13 @@
+2013-05-07 Darin Adler <[email protected]>
+
+ [Win] Fix storage leak in Windows DumpRenderTree
+ https://bugs.webkit.org/show_bug.cgi?id=115651
+
+ Reviewed by Sam Weinig.
+
+ * DumpRenderTree/win/DumpRenderTree.cpp:
+ (lastPathComponent): Added a missing call to adoptCF.
+
2013-05-07 Alex Christensen <[email protected]>
fixed a memory leak introduced by bug 42324 by using a RetainPtr
Modified: trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp (149702 => 149703)
--- trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp 2013-05-08 01:13:34 UTC (rev 149702)
+++ trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp 2013-05-08 01:26:34 UTC (rev 149703)
@@ -176,7 +176,7 @@
return urlString;
RetainPtr<CFURLRef> url(AdoptCF, CFURLCreateWithBytes(kCFAllocatorDefault, reinterpret_cast<const UInt8*>(urlString.c_str()), urlString.length() * sizeof(wstring::value_type), kCFStringEncodingUTF16, 0));
- RetainPtr<CFStringRef> lastPathComponent(CFURLCopyLastPathComponent(url.get()));
+ RetainPtr<CFStringRef> lastPathComponent = adoptCF(CFURLCopyLastPathComponent(url.get()));
return cfStringRefToWString(lastPathComponent.get());
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
