Title: [149718] trunk/Source/WebCore
- Revision
- 149718
- Author
- [email protected]
- Date
- 2013-05-08 00:58:17 -0700 (Wed, 08 May 2013)
Log Message
Remove unused method and de-virtualize others in Element.h
https://bugs.webkit.org/show_bug.cgi?id=115770
Reviewed by Andreas Kling.
Merge https://chromium.googlesource.com/chromium/blink/+/c2c2ff9cb69f46f5cc9d289b2bfbdb8ab5bd3e49
The de-virtualization possibilities were noted whilst "FINALizing" the Node
hierarchy. If a method is successfully marked FINAL but then fails when marked
OVERRIDE as well, the method by definition does not need to be virtual.
* WebCore.exp.in:
* dom/Element.h:
(WebCore::Element::hasAuthorShadowRoot):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (149717 => 149718)
--- trunk/Source/WebCore/ChangeLog 2013-05-08 07:51:48 UTC (rev 149717)
+++ trunk/Source/WebCore/ChangeLog 2013-05-08 07:58:17 UTC (rev 149718)
@@ -1,3 +1,20 @@
+2013-05-08 Ryosuke Niwa <[email protected]>
+
+ Remove unused method and de-virtualize others in Element.h
+ https://bugs.webkit.org/show_bug.cgi?id=115770
+
+ Reviewed by Andreas Kling.
+
+ Merge https://chromium.googlesource.com/chromium/blink/+/c2c2ff9cb69f46f5cc9d289b2bfbdb8ab5bd3e49
+
+ The de-virtualization possibilities were noted whilst "FINALizing" the Node
+ hierarchy. If a method is successfully marked FINAL but then fails when marked
+ OVERRIDE as well, the method by definition does not need to be virtual.
+
+ * WebCore.exp.in:
+ * dom/Element.h:
+ (WebCore::Element::hasAuthorShadowRoot):
+
2013-05-06 Darin Adler <[email protected]>
Use adoptCF and adoptNS in more places
Modified: trunk/Source/WebCore/WebCore.exp.in (149717 => 149718)
--- trunk/Source/WebCore/WebCore.exp.in 2013-05-08 07:51:48 UTC (rev 149717)
+++ trunk/Source/WebCore/WebCore.exp.in 2013-05-08 07:58:17 UTC (rev 149718)
@@ -1608,6 +1608,7 @@
__ZNK7WebCore7Element12getAttributeERKNS_13QualifiedNameE
__ZNK7WebCore7Element12hasAttributeERKN3WTF12AtomicStringE
__ZNK7WebCore7Element13pseudoElementENS_8PseudoIdE
+__ZNK7WebCore7Element25containsFullScreenElementEv
__ZNK7WebCore7Element6shadowEv
__ZNK7WebCore7IntRect10intersectsERKS0_
__ZNK7WebCore7IntRect8containsERKS0_
Modified: trunk/Source/WebCore/dom/Element.h (149717 => 149718)
--- trunk/Source/WebCore/dom/Element.h 2013-05-08 07:51:48 UTC (rev 149717)
+++ trunk/Source/WebCore/dom/Element.h 2013-05-08 07:58:17 UTC (rev 149718)
@@ -418,7 +418,6 @@
ShadowRoot* authorShadowRoot() const;
bool hasAuthorShadowRoot() const { return authorShadowRoot(); }
- virtual void willAddAuthorShadowRoot() { }
ShadowRoot* userAgentShadowRoot() const;
ShadowRoot* ensureUserAgentShadowRoot();
@@ -588,9 +587,9 @@
};
void webkitRequestFullScreen(unsigned short flags);
- virtual bool containsFullScreenElement() const;
- virtual void setContainsFullScreenElement(bool);
- virtual void setContainsFullScreenElementOnAncestorsCrossingFrameBoundaries(bool);
+ bool containsFullScreenElement() const;
+ void setContainsFullScreenElement(bool);
+ void setContainsFullScreenElementOnAncestorsCrossingFrameBoundaries(bool);
// W3C API
void webkitRequestFullscreen();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
