Title: [149721] trunk/Tools
- Revision
- 149721
- Author
- [email protected]
- Date
- 2013-05-08 01:14:49 -0700 (Wed, 08 May 2013)
Log Message
[Flakiness Dashboard] Remove the Chromium fallback platforms listing from the legend popup
https://bugs.webkit.org/show_bug.cgi?id=115636
Reviewed by Ryosuke Niwa.
* TestResultServer/static-dashboards/flakiness_dashboard.js:
(showLegend): Remove the listing of the Chromium fallback platforms from the legend popup. The code iterated
through the platforms in the g_fallbacksMap dictionary to construct this part of the legend, but the dictionary,
while Chromium-specific, can't be removed just yet as there's more code that uses it.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (149720 => 149721)
--- trunk/Tools/ChangeLog 2013-05-08 08:06:00 UTC (rev 149720)
+++ trunk/Tools/ChangeLog 2013-05-08 08:14:49 UTC (rev 149721)
@@ -1,3 +1,15 @@
+2013-05-08 Zan Dobersek <[email protected]>
+
+ [Flakiness Dashboard] Remove the Chromium fallback platforms listing from the legend popup
+ https://bugs.webkit.org/show_bug.cgi?id=115636
+
+ Reviewed by Ryosuke Niwa.
+
+ * TestResultServer/static-dashboards/flakiness_dashboard.js:
+ (showLegend): Remove the listing of the Chromium fallback platforms from the legend popup. The code iterated
+ through the platforms in the g_fallbacksMap dictionary to construct this part of the legend, but the dictionary,
+ while Chromium-specific, can't be removed just yet as there's more code that uses it.
+
2013-05-06 Darin Adler <[email protected]>
Use adoptCF and adoptNS in more places, test code and code not compiled on Mac
Modified: trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js (149720 => 149721)
--- trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js 2013-05-08 08:06:00 UTC (rev 149720)
+++ trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js 2013-05-08 08:14:49 UTC (rev 149721)
@@ -2440,11 +2440,6 @@
g_fallbacksMap['LINUX-32'] = ['chromium-linux-x86', 'chromium-linux', 'chromium-win', 'chromium'];
g_fallbacksMap['LINUX-64'] = ['chromium-linux', 'chromium-win', 'chromium'];
-function htmlForFallbackHelp(fallbacks)
-{
- return '<ol class=fallback-list><li>' + fallbacks.join('</li><li>') + '</li></ol>';
-}
-
function showLegend()
{
var legend = $('legend');
@@ -2460,18 +2455,11 @@
html += '<div class=' + expectation + '>' + expectationsMap()[expectation] + '</div>';
html += '<div class=merge>WEBKIT MERGE</div>';
- if (g_history.isLayoutTestResults()) {
- html += '</div><br style="clear:both">' +
- '</div><h3>Test expectatons fallback order.</h3>';
-
- for (var platform in g_fallbacksMap)
- html += '<div class=fallback-header>' + platform + '</div>' + htmlForFallbackHelp(g_fallbacksMap[platform]);
-
- html += '<div>TIMES:</div>' +
+ if (g_history.isLayoutTestResults())
+ html += '</div><br style="clear:both"><div>TIMES:</div>' +
htmlForSlowTimes(MIN_SECONDS_FOR_SLOW_TEST) +
'<div>DEBUG TIMES:</div>' +
htmlForSlowTimes(MIN_SECONDS_FOR_SLOW_TEST_DEBUG);
- }
legend.innerHTML = html;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
