Title: [149757] trunk/Tools
- Revision
- 149757
- Author
- [email protected]
- Date
- 2013-05-08 12:26:16 -0700 (Wed, 08 May 2013)
Log Message
new-run-webkit-websocketserver doesn't work after Chromium removal
https://bugs.webkit.org/show_bug.cgi?id=115816
Reviewed by Joseph Pecoraro.
Fix the bug by instantiating the correct port object.
* Scripts/new-run-webkit-websocketserver:
(main):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (149756 => 149757)
--- trunk/Tools/ChangeLog 2013-05-08 19:19:32 UTC (rev 149756)
+++ trunk/Tools/ChangeLog 2013-05-08 19:26:16 UTC (rev 149757)
@@ -1,3 +1,15 @@
+2013-05-08 Ryosuke Niwa <[email protected]>
+
+ new-run-webkit-websocketserver doesn't work after Chromium removal
+ https://bugs.webkit.org/show_bug.cgi?id=115816
+
+ Reviewed by Joseph Pecoraro.
+
+ Fix the bug by instantiating the correct port object.
+
+ * Scripts/new-run-webkit-websocketserver:
+ (main):
+
2013-05-07 Lucas Forschler <[email protected]>
Configure buildbot for 32bit builder.
Modified: trunk/Tools/Scripts/new-run-webkit-websocketserver (149756 => 149757)
--- trunk/Tools/Scripts/new-run-webkit-websocketserver 2013-05-08 19:19:32 UTC (rev 149756)
+++ trunk/Tools/Scripts/new-run-webkit-websocketserver 2013-05-08 19:26:16 UTC (rev 149757)
@@ -36,6 +36,7 @@
from webkitpy.common.host import Host
from webkitpy.layout_tests.servers import websocket_server
+from webkitpy.port import platform_options
def main():
@@ -71,6 +72,11 @@
option_parser.add_option('-v', '--verbose', action='',
default=False,
help='Include debug-level logging.')
+
+ option_group = optparse.OptionGroup(option_parser, "Platform options")
+ option_group.add_options(platform_options())
+ option_parser.add_option_group(option_group)
+
options, args = option_parser.parse_args()
if not options.port:
@@ -97,8 +103,7 @@
kwds['pidfile'] = options.pidfile
host = Host()
- # FIXME: Make this work with other ports as well.
- port_obj = host.port_factory.get(port_name='chromium', options=options)
+ port_obj = host.port_factory.get(options.platform, options=options)
pywebsocket = websocket_server.PyWebSocket(port_obj, options.output_dir, **kwds)
log_level = logging.WARN
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
