Title: [149785] trunk/Source/WebCore
- Revision
- 149785
- Author
- [email protected]
- Date
- 2013-05-08 18:11:41 -0700 (Wed, 08 May 2013)
Log Message
Remove Editor::setSelectionOffsets
https://bugs.webkit.org/show_bug.cgi?id=115831
Reviewed by Andreas Kling.
Removed the function added in r120985 for Chromium Android port.
* editing/Editor.cpp:
* editing/Editor.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (149784 => 149785)
--- trunk/Source/WebCore/ChangeLog 2013-05-09 01:02:20 UTC (rev 149784)
+++ trunk/Source/WebCore/ChangeLog 2013-05-09 01:11:41 UTC (rev 149785)
@@ -1,3 +1,15 @@
+2013-05-08 Ryosuke Niwa <[email protected]>
+
+ Remove Editor::setSelectionOffsets
+ https://bugs.webkit.org/show_bug.cgi?id=115831
+
+ Reviewed by Andreas Kling.
+
+ Removed the function added in r120985 for Chromium Android port.
+
+ * editing/Editor.cpp:
+ * editing/Editor.h:
+
2013-05-07 Ryosuke Niwa <[email protected]>
Potential use-after-free of Frame
Modified: trunk/Source/WebCore/editing/Editor.cpp (149784 => 149785)
--- trunk/Source/WebCore/editing/Editor.cpp 2013-05-09 01:02:20 UTC (rev 149784)
+++ trunk/Source/WebCore/editing/Editor.cpp 2013-05-09 01:11:41 UTC (rev 149785)
@@ -2524,19 +2524,6 @@
return true;
}
-bool Editor::setSelectionOffsets(int selectionStart, int selectionEnd)
-{
- Element* rootEditableElement = m_frame->selection()->rootEditableElement();
- if (!rootEditableElement)
- return false;
-
- RefPtr<Range> range = TextIterator::rangeFromLocationAndLength(rootEditableElement, selectionStart, selectionEnd - selectionStart);
- if (!range)
- return false;
-
- return m_frame->selection()->setSelectedRange(range.get(), VP_DEFAULT_AFFINITY, false);
-}
-
void Editor::transpose()
{
if (!canEdit())
Modified: trunk/Source/WebCore/editing/Editor.h (149784 => 149785)
--- trunk/Source/WebCore/editing/Editor.h 2013-05-09 01:02:20 UTC (rev 149784)
+++ trunk/Source/WebCore/editing/Editor.h 2013-05-09 01:11:41 UTC (rev 149785)
@@ -313,7 +313,6 @@
bool cancelCompositionIfSelectionIsInvalid();
PassRefPtr<Range> compositionRange() const;
bool getCompositionSelection(unsigned& selectionStart, unsigned& selectionEnd) const;
- bool setSelectionOffsets(int selectionStart, int selectionEnd);
// getting international text input composition state (for use by InlineTextBox)
Text* compositionNode() const { return m_compositionNode.get(); }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
