Title: [149794] trunk/Source/WebCore
Revision
149794
Author
[email protected]
Date
2013-05-08 23:39:22 -0700 (Wed, 08 May 2013)

Log Message

Fix some compiler warnings (miscellaneous)
https://bugs.webkit.org/show_bug.cgi?id=80790

Patch by Rob Buis <[email protected]> on 2013-05-08
Reviewed by Brent Fulgham.

Get rid of the following warning for BlackBerry:

NavigatorContentUtils.cpp:60:78: warning: comparison of unsigned _expression_ < 0 is always false [-Wtype-limits]

by not compiling any of the code to add protocols to the protocol whitelist.

* Modules/navigatorcontentutils/NavigatorContentUtils.cpp:
(WebCore::initProtocolHandlerWhitelist):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (149793 => 149794)


--- trunk/Source/WebCore/ChangeLog	2013-05-09 06:38:18 UTC (rev 149793)
+++ trunk/Source/WebCore/ChangeLog	2013-05-09 06:39:22 UTC (rev 149794)
@@ -1,3 +1,19 @@
+2013-05-08  Rob Buis  <[email protected]>
+
+        Fix some compiler warnings (miscellaneous)
+        https://bugs.webkit.org/show_bug.cgi?id=80790
+
+        Reviewed by Brent Fulgham.
+
+        Get rid of the following warning for BlackBerry:
+
+        NavigatorContentUtils.cpp:60:78: warning: comparison of unsigned _expression_ < 0 is always false [-Wtype-limits]
+
+        by not compiling any of the code to add protocols to the protocol whitelist.
+
+        * Modules/navigatorcontentutils/NavigatorContentUtils.cpp:
+        (WebCore::initProtocolHandlerWhitelist):
+
 2013-05-08  [email protected]  <[email protected]>
 
         [Windows] The function seekFile() is not implemented.

Modified: trunk/Source/WebCore/Modules/navigatorcontentutils/NavigatorContentUtils.cpp (149793 => 149794)


--- trunk/Source/WebCore/Modules/navigatorcontentutils/NavigatorContentUtils.cpp	2013-05-09 06:38:18 UTC (rev 149793)
+++ trunk/Source/WebCore/Modules/navigatorcontentutils/NavigatorContentUtils.cpp	2013-05-09 06:39:22 UTC (rev 149794)
@@ -43,8 +43,8 @@
 static void initProtocolHandlerWhitelist()
 {
     protocolWhitelist = new HashSet<String>;
+#if !PLATFORM(BLACKBERRY)
     static const char* protocols[] = {
-#if !PLATFORM(BLACKBERRY)
         "irc",
         "mailto",
         "mms",
@@ -55,10 +55,10 @@
         "tel",
         "urn",
         "webcal",
-#endif
     };
     for (size_t i = 0; i < WTF_ARRAY_LENGTH(protocols); ++i)
         protocolWhitelist->add(protocols[i]);
+#endif
 }
 
 static bool verifyCustomHandlerURL(const String& baseURL, const String& url, ExceptionCode& ec)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to