Title: [149800] trunk/Source/WebKit/qt
Revision
149800
Author
[email protected]
Date
2013-05-09 06:11:30 -0700 (Thu, 09 May 2013)

Log Message

[Qt][WK1]REGRESSION(r149532) tst_qwebelement and tst_qwebframe API tests crash.
<http://webkit.org/b/115855>

Fix obvious off-by-one mistake.

* Api/qwebelement.cpp:
(QWebElement::styleProperty):

Modified Paths

Diff

Modified: trunk/Source/WebKit/qt/Api/qwebelement.cpp (149799 => 149800)


--- trunk/Source/WebKit/qt/Api/qwebelement.cpp	2013-05-09 09:18:20 UTC (rev 149799)
+++ trunk/Source/WebKit/qt/Api/qwebelement.cpp	2013-05-09 13:11:30 UTC (rev 149800)
@@ -836,7 +836,7 @@
         Document* doc = m_element->document();
         Vector<RefPtr<StyleRuleBase> > rules = doc->ensureStyleResolver()->styleRulesForElement(m_element, StyleResolver::AuthorCSSRules | StyleResolver::CrossOriginCSSRules);
         for (int i = rules.size(); i > 0; --i) {
-            if (!rules[i]->isStyleRule())
+            if (!rules[i - 1]->isStyleRule())
                 continue;
             StyleRule* styleRule = static_cast<StyleRule*>(rules[i - 1].get());
 

Modified: trunk/Source/WebKit/qt/ChangeLog (149799 => 149800)


--- trunk/Source/WebKit/qt/ChangeLog	2013-05-09 09:18:20 UTC (rev 149799)
+++ trunk/Source/WebKit/qt/ChangeLog	2013-05-09 13:11:30 UTC (rev 149800)
@@ -1,3 +1,13 @@
+2013-05-09  Andreas Kling  <[email protected]>
+
+        [Qt][WK1]REGRESSION(r149532) tst_qwebelement and tst_qwebframe API tests crash.
+        <http://webkit.org/b/115855>
+
+        Fix obvious off-by-one mistake.
+
+        * Api/qwebelement.cpp:
+        (QWebElement::styleProperty):
+
 2013-05-07  Allan Sandfeld Jensen  <[email protected]>
 
         Crash when calling QWebFrame::evaluateJavaScript
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to