Title: [149804] trunk/Source/WebKit2
- Revision
- 149804
- Author
- [email protected]
- Date
- 2013-05-09 07:03:13 -0700 (Thu, 09 May 2013)
Log Message
Make dragging off a tab in Safari with a docked Inspector reattach the Inspector.
https://webkit.org/b/115832
rdar://problem/13605661
Reviewed by Benjamin Poulain.
* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformBringToFront):
If the Web Inspector is no longer in the same window as the inspected view,
then we need to reopen the Inspector to get it attached to the right window.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (149803 => 149804)
--- trunk/Source/WebKit2/ChangeLog 2013-05-09 13:50:14 UTC (rev 149803)
+++ trunk/Source/WebKit2/ChangeLog 2013-05-09 14:03:13 UTC (rev 149804)
@@ -1,3 +1,17 @@
+2013-05-09 Timothy Hatcher <[email protected]>
+
+ Make dragging off a tab in Safari with a docked Inspector reattach the Inspector.
+
+ https://webkit.org/b/115832
+ rdar://problem/13605661
+
+ Reviewed by Benjamin Poulain.
+
+ * UIProcess/mac/WebInspectorProxyMac.mm:
+ (WebKit::WebInspectorProxy::platformBringToFront):
+ If the Web Inspector is no longer in the same window as the inspected view,
+ then we need to reopen the Inspector to get it attached to the right window.
+
2013-05-08 Anders Carlsson <[email protected]>
Fix a typo in a comment.
Modified: trunk/Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm (149803 => 149804)
--- trunk/Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm 2013-05-09 13:50:14 UTC (rev 149803)
+++ trunk/Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm 2013-05-09 14:03:13 UTC (rev 149804)
@@ -473,6 +473,14 @@
void WebInspectorProxy::platformBringToFront()
{
+ // If the Web Inspector is no longer in the same window as the inspected view,
+ // then we need to reopen the Inspector to get it attached to the right window.
+ // This can happen when dragging tabs to another window in Safari.
+ if (m_isAttached && m_inspectorView.get().window != m_page->wkView().window) {
+ platformOpen();
+ return;
+ }
+
// FIXME <rdar://problem/10937688>: this will not bring a background tab in Safari to the front, only its window.
[m_inspectorView.get().window makeKeyAndOrderFront:nil];
[m_inspectorView.get().window makeFirstResponder:m_inspectorView.get()];
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
