Title: [149867] trunk/Source/WebCore
- Revision
- 149867
- Author
- [email protected]
- Date
- 2013-05-10 05:17:14 -0700 (Fri, 10 May 2013)
Log Message
Remove overflow dead code
https://bugs.webkit.org/show_bug.cgi?id=115893
Reviewed by Antti Koivisto.
The patch removes unused public overflow accesor functions from RenderOverflow and InlineFlowBox.
Tests: no tests, code cleanup.
* rendering/InlineFlowBox.h: Removed logicalLeftLayoutOverflow and logicalRightLayoutOverflow.
* rendering/RenderOverflow.h: Removed setMinYLayoutOverflow, setMaxYLayoutOverflow,
setMinXLayoutOverflow, setMaxXLayoutOverflow, setMinYVisualOverflow, setMaxYVisualOverflow,
setMinXVisualOverflow and setMaxXVisualOverflow.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (149866 => 149867)
--- trunk/Source/WebCore/ChangeLog 2013-05-10 11:59:15 UTC (rev 149866)
+++ trunk/Source/WebCore/ChangeLog 2013-05-10 12:17:14 UTC (rev 149867)
@@ -1,3 +1,19 @@
+2013-05-10 Andrei Bucur <[email protected]>
+
+ Remove overflow dead code
+ https://bugs.webkit.org/show_bug.cgi?id=115893
+
+ Reviewed by Antti Koivisto.
+
+ The patch removes unused public overflow accesor functions from RenderOverflow and InlineFlowBox.
+
+ Tests: no tests, code cleanup.
+
+ * rendering/InlineFlowBox.h: Removed logicalLeftLayoutOverflow and logicalRightLayoutOverflow.
+ * rendering/RenderOverflow.h: Removed setMinYLayoutOverflow, setMaxYLayoutOverflow,
+ setMinXLayoutOverflow, setMaxXLayoutOverflow, setMinYVisualOverflow, setMaxYVisualOverflow,
+ setMinXVisualOverflow and setMaxXVisualOverflow.
+
2013-05-10 Anders Carlsson <[email protected]>
Begin making SecurityOrigin immutable
Modified: trunk/Source/WebCore/rendering/InlineFlowBox.h (149866 => 149867)
--- trunk/Source/WebCore/rendering/InlineFlowBox.h 2013-05-10 11:59:15 UTC (rev 149866)
+++ trunk/Source/WebCore/rendering/InlineFlowBox.h 2013-05-10 12:17:14 UTC (rev 149867)
@@ -219,16 +219,6 @@
{
return m_overflow ? m_overflow->layoutOverflowRect() : enclosingLayoutRect(frameRectIncludingLineHeight(lineTop, lineBottom));
}
- LayoutUnit logicalLeftLayoutOverflow() const
- {
- return m_overflow ? (isHorizontal() ? m_overflow->layoutOverflowRect().x() : m_overflow->layoutOverflowRect().y()) :
- static_cast<LayoutUnit>(logicalLeft());
- }
- LayoutUnit logicalRightLayoutOverflow() const
- {
- return m_overflow ? (isHorizontal() ? m_overflow->layoutOverflowRect().maxX() : m_overflow->layoutOverflowRect().maxY()) :
- static_cast<LayoutUnit>(ceilf(logicalRight()));
- }
LayoutUnit logicalTopLayoutOverflow(LayoutUnit lineTop) const
{
if (m_overflow)
Modified: trunk/Source/WebCore/rendering/RenderOverflow.h (149866 => 149867)
--- trunk/Source/WebCore/rendering/RenderOverflow.h 2013-05-10 11:59:15 UTC (rev 149866)
+++ trunk/Source/WebCore/rendering/RenderOverflow.h 2013-05-10 12:17:14 UTC (rev 149867)
@@ -48,17 +48,7 @@
const LayoutRect layoutOverflowRect() const { return m_layoutOverflow; }
const LayoutRect visualOverflowRect() const { return m_visualOverflow; }
-
- void setMinYLayoutOverflow(LayoutUnit overflow) { m_layoutOverflow.setY(overflow); }
- void setMaxYLayoutOverflow(LayoutUnit overflow) { m_layoutOverflow.setHeight(overflow - m_layoutOverflow.y()); }
- void setMinXLayoutOverflow(LayoutUnit overflow) { m_layoutOverflow.setX(overflow); }
- void setMaxXLayoutOverflow(LayoutUnit overflow) { m_layoutOverflow.setWidth(overflow - m_layoutOverflow.x()); }
- void setMinYVisualOverflow(LayoutUnit overflow) { m_visualOverflow.setY(overflow); }
- void setMaxYVisualOverflow(LayoutUnit overflow) { m_visualOverflow.setHeight(overflow - m_layoutOverflow.y()); }
- void setMinXVisualOverflow(LayoutUnit overflow) { m_visualOverflow.setX(overflow); }
- void setMaxXVisualOverflow(LayoutUnit overflow) { m_visualOverflow.setWidth(overflow - m_layoutOverflow.x()); }
-
void move(LayoutUnit dx, LayoutUnit dy);
void addLayoutOverflow(const LayoutRect&);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
