Title: [149885] trunk/Source/WebKit2
- Revision
- 149885
- Author
- [email protected]
- Date
- 2013-05-10 10:20:59 -0700 (Fri, 10 May 2013)
Log Message
REGRESSION (r149439): Video turns blank upon entering full screen for the first time
https://bugs.webkit.org/show_bug.cgi?id=115617
Reviewed by Eric Carlson.
Partially revert the change introduced in r149439 for OS X 10.8 and previous. On these
platforms, create a window with a NSZeroSize initial frame, which fixes the "blank"
first-full screen behavior.
* UIProcess/API/mac/WKView.mm:
(-[WKView createFullScreenWindow]):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (149884 => 149885)
--- trunk/Source/WebKit2/ChangeLog 2013-05-10 17:16:54 UTC (rev 149884)
+++ trunk/Source/WebKit2/ChangeLog 2013-05-10 17:20:59 UTC (rev 149885)
@@ -1,3 +1,17 @@
+2013-05-10 Jer Noble <[email protected]>
+
+ REGRESSION (r149439): Video turns blank upon entering full screen for the first time
+ https://bugs.webkit.org/show_bug.cgi?id=115617
+
+ Reviewed by Eric Carlson.
+
+ Partially revert the change introduced in r149439 for OS X 10.8 and previous. On these
+ platforms, create a window with a NSZeroSize initial frame, which fixes the "blank"
+ first-full screen behavior.
+
+ * UIProcess/API/mac/WKView.mm:
+ (-[WKView createFullScreenWindow]):
+
2013-05-10 Zan Dobersek <[email protected]>
[WK2] Make the WebSoupRequestManager a supplement to the WebProcess
Modified: trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm (149884 => 149885)
--- trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm 2013-05-10 17:16:54 UTC (rev 149884)
+++ trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm 2013-05-10 17:20:59 UTC (rev 149885)
@@ -3394,8 +3394,13 @@
- (NSWindow*)createFullScreenWindow
{
#if ENABLE(FULLSCREEN_API)
- return [[[WebCoreFullScreenWindow alloc] initWithContentRect:[[NSScreen mainScreen] frame] styleMask:NSBorderlessWindowMask backing:NSBackingStoreBuffered defer:NO] autorelease];
+#if __MAC_OS_X_VERSION_MIN_REQUIRED <= 1080
+ NSRect contentRect = NSZeroRect;
#else
+ NSRect contentRect = [[NSScreen mainScreen] frame];
+#endif
+ return [[[WebCoreFullScreenWindow alloc] initWithContentRect:contentRect styleMask:NSBorderlessWindowMask backing:NSBackingStoreBuffered defer:NO] autorelease];
+#else
return nil;
#endif
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
