Title: [149887] trunk/Source/WebCore
- Revision
- 149887
- Author
- [email protected]
- Date
- 2013-05-10 10:36:29 -0700 (Fri, 10 May 2013)
Log Message
[GTK] Generated files are regenerated always
https://bugs.webkit.org/show_bug.cgi?id=115908
Reviewed by Carlos Garcia Campos.
No new tests - no change in functionality.
* GNUmakefile.am: Don't treat the window constructors IDL file as a dependency of the _javascript_Core bindings.
The file is generated during the IDL preprocessing, and the JSC bindings already depend on that step through
the idl_supplemental_dependencies file. Because of that the window constructors IDL file has a phony target
which seems to confuse the bindings generation rule into thinking that a complete regeration of the bindings is required.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (149886 => 149887)
--- trunk/Source/WebCore/ChangeLog 2013-05-10 17:34:36 UTC (rev 149886)
+++ trunk/Source/WebCore/ChangeLog 2013-05-10 17:36:29 UTC (rev 149887)
@@ -1,3 +1,17 @@
+2013-05-10 Zan Dobersek <[email protected]>
+
+ [GTK] Generated files are regenerated always
+ https://bugs.webkit.org/show_bug.cgi?id=115908
+
+ Reviewed by Carlos Garcia Campos.
+
+ No new tests - no change in functionality.
+
+ * GNUmakefile.am: Don't treat the window constructors IDL file as a dependency of the _javascript_Core bindings.
+ The file is generated during the IDL preprocessing, and the JSC bindings already depend on that step through
+ the idl_supplemental_dependencies file. Because of that the window constructors IDL file has a phony target
+ which seems to confuse the bindings generation rule into thinking that a complete regeration of the bindings is required.
+
2013-05-10 Andreas Kling <[email protected]>
Caching of generated images in CSS should be smarter.
Modified: trunk/Source/WebCore/GNUmakefile.am (149886 => 149887)
--- trunk/Source/WebCore/GNUmakefile.am 2013-05-10 17:34:36 UTC (rev 149886)
+++ trunk/Source/WebCore/GNUmakefile.am 2013-05-10 17:36:29 UTC (rev 149887)
@@ -425,7 +425,7 @@
DerivedSources/WebCore/JS%.cpp: DerivedSources/WebCore/JS%.h;
.SECONDARY:
-DerivedSources/WebCore/JS%.h: %.idl $(SCRIPTS_FOR_GENERATE_BINDINGS) $(WebCore)/bindings/scripts/CodeGeneratorJS.pm $(supplemental_dependency_file) $(idl_attributes_file) $(window_constructors_file)
+DerivedSources/WebCore/JS%.h: %.idl $(SCRIPTS_FOR_GENERATE_BINDINGS) $(WebCore)/bindings/scripts/CodeGeneratorJS.pm $(supplemental_dependency_file) $(idl_attributes_file)
$(AM_V_GEN)$(PERL) -I$(WebCore)/bindings/scripts $(WebCore)/bindings/scripts/generate-bindings.pl $(IDL_PATH:%=--include "%") --outputDir "$(GENSOURCES_WEBCORE)" --defines "LANGUAGE_JAVASCRIPT=1 $(feature_defines)" --generator JS --idlAttributesFile $(idl_attributes_file) --supplementalDependencyFile $(supplemental_dependency_file) $<
.SECONDARY:
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
