Title: [149950] trunk/Source/WebCore
Revision
149950
Author
[email protected]
Date
2013-05-11 22:39:14 -0700 (Sat, 11 May 2013)

Log Message

Add more info to compositing log channel output
https://bugs.webkit.org/show_bug.cgi?id=115978

Reviewed by Dean Jackson.

Add to compositing log channel output whether a layer paints
into its compositing ancestor.

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::logLayerInfo):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (149949 => 149950)


--- trunk/Source/WebCore/ChangeLog	2013-05-12 04:54:04 UTC (rev 149949)
+++ trunk/Source/WebCore/ChangeLog	2013-05-12 05:39:14 UTC (rev 149950)
@@ -1,3 +1,16 @@
+2013-05-11  Simon Fraser  <[email protected]>
+
+        Add more info to compositing log channel output
+        https://bugs.webkit.org/show_bug.cgi?id=115978
+
+        Reviewed by Dean Jackson.
+
+        Add to compositing log channel output whether a layer paints
+        into its compositing ancestor.
+
+        * rendering/RenderLayerCompositor.cpp:
+        (WebCore::RenderLayerCompositor::logLayerInfo):
+
 2013-05-10  Simon Fraser  <[email protected]>
 
         REGRESSION: Fixed background on ColterReed.com scrolls

Modified: trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp (149949 => 149950)


--- trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp	2013-05-12 04:54:04 UTC (rev 149949)
+++ trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp	2013-05-12 05:39:14 UTC (rev 149950)
@@ -619,10 +619,27 @@
         m_secondaryBackingStoreBytes += backing->backingStoreMemoryEstimate();
     }
 
-    LOG(Compositing, "%*p %dx%d %.2fKB %s(%s) %s\n", 12 + depth * 2, layer, backing->compositedBounds().width(), backing->compositedBounds().height(),
-        backing->backingStoreMemoryEstimate() / 1024,
-        backing->graphicsLayer()->contentsOpaque() ? "opaque " : "",
-        logReasonsForCompositing(layer), layer->name().utf8().data());
+    StringBuilder logString;
+    logString.append(String::format("%*p %dx%d %.2fKB", 12 + depth * 2, layer,
+        backing->compositedBounds().width(), backing->compositedBounds().height(),
+        backing->backingStoreMemoryEstimate() / 1024));
+    
+    logString.append(" (");
+    logString.append(logReasonsForCompositing(layer));
+    logString.append(") ");
+
+    if (backing->graphicsLayer()->contentsOpaque() || backing->paintsIntoCompositedAncestor()) {
+        logString.append('[');
+        if (backing->graphicsLayer()->contentsOpaque())
+            logString.append("opaque");
+        if (backing->paintsIntoCompositedAncestor())
+            logString.append("paints into ancestor");
+        logString.append("] ");
+    }
+
+    logString.append(layer->name());
+
+    LOG(Compositing, "%s", logString.toString().utf8().data());
 }
 #endif
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to