Title: [149959] trunk/Source/WebCore
- Revision
- 149959
- Author
- [email protected]
- Date
- 2013-05-12 07:23:09 -0700 (Sun, 12 May 2013)
Log Message
Devirtualize some things on Document.
>From Blink r149967 by <[email protected]>
<http://src.chromium.org/viewvc/blink?view=revision&revision=149967>
Several methods on Document are virtual but don't override a super class method
and don't need to be virtual. This patch devirtualizes:
- createElementNS()
- finishedParsing()
- suspendScriptedAnimationControllerCallbacks()
- resumeScriptedAnimationControllerCallbacks()
It also removes the suspend and resume callbacks from ScriptExecutionContext
since they didn't need to be there.
* dom/Document.h:
* dom/ScriptExecutionContext.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (149958 => 149959)
--- trunk/Source/WebCore/ChangeLog 2013-05-12 14:11:47 UTC (rev 149958)
+++ trunk/Source/WebCore/ChangeLog 2013-05-12 14:23:09 UTC (rev 149959)
@@ -1,5 +1,26 @@
2013-05-12 Andreas Kling <[email protected]>
+ Devirtualize some things on Document.
+
+ From Blink r149967 by <[email protected]>
+ <http://src.chromium.org/viewvc/blink?view=revision&revision=149967>
+
+ Several methods on Document are virtual but don't override a super class method
+ and don't need to be virtual. This patch devirtualizes:
+
+ - createElementNS()
+ - finishedParsing()
+ - suspendScriptedAnimationControllerCallbacks()
+ - resumeScriptedAnimationControllerCallbacks()
+
+ It also removes the suspend and resume callbacks from ScriptExecutionContext
+ since they didn't need to be there.
+
+ * dom/Document.h:
+ * dom/ScriptExecutionContext.h:
+
+2013-05-12 Andreas Kling <[email protected]>
+
Remove redundant call to removeAllEventListeners() in Document::open().
From Blink r150175 by <[email protected]>
Modified: trunk/Source/WebCore/dom/Document.h (149958 => 149959)
--- trunk/Source/WebCore/dom/Document.h 2013-05-12 14:11:47 UTC (rev 149958)
+++ trunk/Source/WebCore/dom/Document.h 2013-05-12 14:23:09 UTC (rev 149959)
@@ -358,7 +358,7 @@
PassRefPtr<EntityReference> createEntityReference(const String& name, ExceptionCode&);
PassRefPtr<Node> importNode(Node* importedNode, ExceptionCode& ec) { return importNode(importedNode, true, ec); }
PassRefPtr<Node> importNode(Node* importedNode, bool deep, ExceptionCode&);
- virtual PassRefPtr<Element> createElementNS(const String& namespaceURI, const String& qualifiedName, ExceptionCode&);
+ PassRefPtr<Element> createElementNS(const String& namespaceURI, const String& qualifiedName, ExceptionCode&);
PassRefPtr<Element> createElement(const QualifiedName&, bool createdByParser);
bool cssStickyPositionEnabled() const;
@@ -945,12 +945,12 @@
virtual void postTask(PassOwnPtr<Task>); // Executes the task on context's thread asynchronously.
- virtual void suspendScriptedAnimationControllerCallbacks();
- virtual void resumeScriptedAnimationControllerCallbacks();
+ void suspendScriptedAnimationControllerCallbacks();
+ void resumeScriptedAnimationControllerCallbacks();
void windowScreenDidChange(PlatformDisplayID);
- virtual void finishedParsing();
+ void finishedParsing();
bool inPageCache() const { return m_inPageCache; }
void setInPageCache(bool flag);
Modified: trunk/Source/WebCore/dom/ScriptExecutionContext.h (149958 => 149959)
--- trunk/Source/WebCore/dom/ScriptExecutionContext.h 2013-05-12 14:11:47 UTC (rev 149958)
+++ trunk/Source/WebCore/dom/ScriptExecutionContext.h 2013-05-12 14:23:09 UTC (rev 149959)
@@ -111,9 +111,6 @@
void didCreateDestructionObserver(ContextDestructionObserver*);
void willDestroyDestructionObserver(ContextDestructionObserver*);
- virtual void suspendScriptedAnimationControllerCallbacks() { }
- virtual void resumeScriptedAnimationControllerCallbacks() { }
-
// MessagePort is conceptually a kind of ActiveDOMObject, but it needs to be tracked separately for message dispatch.
void processMessagePortMessagesSoon();
void dispatchMessagePortEvents();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
