Title: [149998] trunk/Source/WebKit/mac
- Revision
- 149998
- Author
- [email protected]
- Date
- 2013-05-13 01:37:33 -0700 (Mon, 13 May 2013)
Log Message
[Mac] Layer-backed WebViews draw their background color even when setDrawsBackground:NO was called
https://bugs.webkit.org/show_bug.cgi?id=116014
<rdar://problem/12781227>
Reviewed by Dan Bernstein.
* WebView/WebFrame.mm:
(-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]): Remove calls to setBackgroundColor: and
setDrawsBackground: on the document view. These were added to support a hypothetical document view
that wanted to draw its background like WebHTMLView does, but this was never communicated as a
document view protocol, formal or informal, and it's unlikely that it was ever used. The bug was
caused because there is an -[NSView setDrawsBackground:] method, probably an internal one, and we
were calling it unintentionally on a WebHTMLView.
Modified Paths
Diff
Modified: trunk/Source/WebKit/mac/ChangeLog (149997 => 149998)
--- trunk/Source/WebKit/mac/ChangeLog 2013-05-13 07:55:55 UTC (rev 149997)
+++ trunk/Source/WebKit/mac/ChangeLog 2013-05-13 08:37:33 UTC (rev 149998)
@@ -1,3 +1,19 @@
+2013-05-13 Darin Adler <[email protected]>
+
+ [Mac] Layer-backed WebViews draw their background color even when setDrawsBackground:NO was called
+ https://bugs.webkit.org/show_bug.cgi?id=116014
+ <rdar://problem/12781227>
+
+ Reviewed by Dan Bernstein.
+
+ * WebView/WebFrame.mm:
+ (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]): Remove calls to setBackgroundColor: and
+ setDrawsBackground: on the document view. These were added to support a hypothetical document view
+ that wanted to draw its background like WebHTMLView does, but this was never communicated as a
+ document view protocol, formal or informal, and it's unlikely that it was ever used. The bug was
+ caused because there is an -[NSView setDrawsBackground:] method, probably an internal one, and we
+ were calling it unintentionally on a WebHTMLView.
+
2013-05-12 Anders Carlsson <[email protected]>
Stop including UnusedParam.h
Modified: trunk/Source/WebKit/mac/WebView/WebFrame.mm (149997 => 149998)
--- trunk/Source/WebKit/mac/WebView/WebFrame.mm 2013-05-13 07:55:55 UTC (rev 149997)
+++ trunk/Source/WebKit/mac/WebView/WebFrame.mm 2013-05-13 08:37:33 UTC (rev 149998)
@@ -357,11 +357,6 @@
if (!drawsBackground)
[[[webFrame frameView] _scrollView] setDrawsBackground:NO];
[[[webFrame frameView] _scrollView] setBackgroundColor:backgroundColor];
- id documentView = [[webFrame frameView] documentView];
- if ([documentView respondsToSelector:@selector(setDrawsBackground:)])
- [documentView setDrawsBackground:drawsBackground];
- if ([documentView respondsToSelector:@selector(setBackgroundColor:)])
- [documentView setBackgroundColor:backgroundColor];
if (FrameView* view = frame->view()) {
view->setTransparent(!drawsBackground);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
