Title: [150020] trunk/Source/WebKit2
- Revision
- 150020
- Author
- [email protected]
- Date
- 2013-05-13 09:19:54 -0700 (Mon, 13 May 2013)
Log Message
[WK2] Notification manager removal should not be tied to termination of web processes
https://bugs.webkit.org/show_bug.cgi?id=116038
<rdar://problem/10968680>
Reviewed by Ryosuke Niwa.
WebNotificationManagerProxy incorrectly removes the manager when web processes close.
Since it is a supplemental on the web context, the manager should only be removed
when the context is destroyed.
* UIProcess/Notifications/WebNotificationManagerProxy.cpp:
* UIProcess/Notifications/WebNotificationManagerProxy.h: Remove implementation of
processDidClose().
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (150019 => 150020)
--- trunk/Source/WebKit2/ChangeLog 2013-05-13 16:19:48 UTC (rev 150019)
+++ trunk/Source/WebKit2/ChangeLog 2013-05-13 16:19:54 UTC (rev 150020)
@@ -1,3 +1,19 @@
+2013-05-13 Jon Lee <[email protected]>
+
+ [WK2] Notification manager removal should not be tied to termination of web processes
+ https://bugs.webkit.org/show_bug.cgi?id=116038
+ <rdar://problem/10968680>
+
+ Reviewed by Ryosuke Niwa.
+
+ WebNotificationManagerProxy incorrectly removes the manager when web processes close.
+ Since it is a supplemental on the web context, the manager should only be removed
+ when the context is destroyed.
+
+ * UIProcess/Notifications/WebNotificationManagerProxy.cpp:
+ * UIProcess/Notifications/WebNotificationManagerProxy.h: Remove implementation of
+ processDidClose().
+
2013-05-13 Martin Robinson <[email protected]>
[GTK] [WebKit2] Use a template file for generated GObject enum files
Modified: trunk/Source/WebKit2/UIProcess/Notifications/WebNotificationManagerProxy.cpp (150019 => 150020)
--- trunk/Source/WebKit2/UIProcess/Notifications/WebNotificationManagerProxy.cpp 2013-05-13 16:19:48 UTC (rev 150019)
+++ trunk/Source/WebKit2/UIProcess/Notifications/WebNotificationManagerProxy.cpp 2013-05-13 16:19:54 UTC (rev 150020)
@@ -69,11 +69,6 @@
m_provider.removeNotificationManager(this);
}
-void WebNotificationManagerProxy::processDidClose(WebProcessProxy*)
-{
- m_provider.removeNotificationManager(this);
-}
-
void WebNotificationManagerProxy::refWebContextSupplement()
{
APIObject::ref();
Modified: trunk/Source/WebKit2/UIProcess/Notifications/WebNotificationManagerProxy.h (150019 => 150020)
--- trunk/Source/WebKit2/UIProcess/Notifications/WebNotificationManagerProxy.h 2013-05-13 16:19:48 UTC (rev 150019)
+++ trunk/Source/WebKit2/UIProcess/Notifications/WebNotificationManagerProxy.h 2013-05-13 16:19:54 UTC (rev 150020)
@@ -69,7 +69,6 @@
// WebContextSupplement
virtual void contextDestroyed() OVERRIDE;
- virtual void processDidClose(WebProcessProxy*) OVERRIDE;
virtual void refWebContextSupplement() OVERRIDE;
virtual void derefWebContextSupplement() OVERRIDE;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
