Title: [150124] trunk/Source/WebCore
- Revision
- 150124
- Author
- [email protected]
- Date
- 2013-05-15 09:53:42 -0700 (Wed, 15 May 2013)
Log Message
[Mac] Remove call to ClipboardMac::create from EventHandler::createDraggingClipboard
https://bugs.webkit.org/show_bug.cgi?id=116161
Reviewed by Andreas Kling.
* dom/Clipboard.h: Added createForDragAndDrop function.
* page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::createDraggingClipboard): Changed to use new Clipboard function
instead of ClipboardMac::create.
* platform/mac/ClipboardMac.mm:
(WebCore::Clipboard::createForDragAndDrop): Added. For now it does exactly what the
EventHandler::createDraggingClipboard function did, soon to be refactored better.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (150123 => 150124)
--- trunk/Source/WebCore/ChangeLog 2013-05-15 16:48:32 UTC (rev 150123)
+++ trunk/Source/WebCore/ChangeLog 2013-05-15 16:53:42 UTC (rev 150124)
@@ -1,5 +1,22 @@
2013-05-15 Darin Adler <[email protected]>
+ [Mac] Remove call to ClipboardMac::create from EventHandler::createDraggingClipboard
+ https://bugs.webkit.org/show_bug.cgi?id=116161
+
+ Reviewed by Andreas Kling.
+
+ * dom/Clipboard.h: Added createForDragAndDrop function.
+
+ * page/mac/EventHandlerMac.mm:
+ (WebCore::EventHandler::createDraggingClipboard): Changed to use new Clipboard function
+ instead of ClipboardMac::create.
+
+ * platform/mac/ClipboardMac.mm:
+ (WebCore::Clipboard::createForDragAndDrop): Added. For now it does exactly what the
+ EventHandler::createDraggingClipboard function did, soon to be refactored better.
+
+2013-05-15 Darin Adler <[email protected]>
+
[Mac] Thin out the ClipboardMac class and header file to prepare for deleting them
https://bugs.webkit.org/show_bug.cgi?id=116159
Modified: trunk/Source/WebCore/dom/Clipboard.h (150123 => 150124)
--- trunk/Source/WebCore/dom/Clipboard.h 2013-05-15 16:48:32 UTC (rev 150123)
+++ trunk/Source/WebCore/dom/Clipboard.h 2013-05-15 16:53:42 UTC (rev 150124)
@@ -132,6 +132,8 @@
#endif
#if !USE(LEGACY_STYLE_ABSTRACT_CLIPBOARD_CLASS) && ENABLE(DRAG_SUPPORT)
+ static PassRefPtr<Clipboard> createForDragAndDrop();
+
void updateDragImage();
#endif
Modified: trunk/Source/WebCore/page/mac/EventHandlerMac.mm (150123 => 150124)
--- trunk/Source/WebCore/page/mac/EventHandlerMac.mm 2013-05-15 16:48:32 UTC (rev 150123)
+++ trunk/Source/WebCore/page/mac/EventHandlerMac.mm 2013-05-15 16:53:42 UTC (rev 150124)
@@ -674,10 +674,10 @@
PassRefPtr<Clipboard> EventHandler::createDraggingClipboard() const
{
// Must be done before ondragstart adds types and data to the pboard,
- // also done for security, as it erases data from the last drag
- Pasteboard pasteboard(NSDragPboard);
- pasteboard.clear();
- return ClipboardMac::create(Clipboard::DragAndDrop, String(NSDragPboard), ClipboardWritable, ClipboardMac::DragAndDropData, m_frame);
+ // also done for security, as it erases data from the last drag.
+ OwnPtr<Pasteboard> pasteboard = Pasteboard::create(NSDragPboard);
+ pasteboard->clear();
+ return Clipboard::createForDragAndDrop();
}
#endif
Modified: trunk/Source/WebCore/platform/mac/ClipboardMac.mm (150123 => 150124)
--- trunk/Source/WebCore/platform/mac/ClipboardMac.mm 2013-05-15 16:48:32 UTC (rev 150123)
+++ trunk/Source/WebCore/platform/mac/ClipboardMac.mm 2013-05-15 16:53:42 UTC (rev 150124)
@@ -46,6 +46,11 @@
}
#endif
+PassRefPtr<Clipboard> Clipboard::createForDragAndDrop()
+{
+ return ClipboardMac::create(Clipboard::DragAndDrop, NSDragPboard, ClipboardWritable, ClipboardMac::DragAndDropData, 0);
+}
+
ClipboardMac::ClipboardMac(ClipboardType clipboardType, const String& pasteboardName, ClipboardAccessPolicy policy, ClipboardContents clipboardContents)
: Clipboard(policy, clipboardType, Pasteboard::create(pasteboardName), clipboardContents == DragAndDropFiles)
{
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
