Title: [150199] trunk/Source/_javascript_Core
- Revision
- 150199
- Author
- [email protected]
- Date
- 2013-05-16 12:11:43 -0700 (Thu, 16 May 2013)
Log Message
JSValue shouldn't protect/unprotect its context
https://bugs.webkit.org/show_bug.cgi?id=116234
Reviewed by Mark Hahnenberg.
Our retain on _context is sufficient.
* API/JSValue.mm:
(-[JSValue initWithValue:inContext:]):
(-[JSValue dealloc]):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/API/JSValue.mm (150198 => 150199)
--- trunk/Source/_javascript_Core/API/JSValue.mm 2013-05-16 19:09:57 UTC (rev 150198)
+++ trunk/Source/_javascript_Core/API/JSValue.mm 2013-05-16 19:11:43 UTC (rev 150199)
@@ -971,7 +971,6 @@
_context = [context retain];
m_value = value;
- JSValueProtect([_context JSGlobalContextRef], m_value);
return self;
}
@@ -1089,7 +1088,6 @@
- (void)dealloc
{
- JSValueUnprotect([_context JSGlobalContextRef], m_value);
[_context release];
_context = nil;
[super dealloc];
Modified: trunk/Source/_javascript_Core/ChangeLog (150198 => 150199)
--- trunk/Source/_javascript_Core/ChangeLog 2013-05-16 19:09:57 UTC (rev 150198)
+++ trunk/Source/_javascript_Core/ChangeLog 2013-05-16 19:11:43 UTC (rev 150199)
@@ -1,3 +1,16 @@
+2013-05-16 Geoffrey Garen <[email protected]>
+
+ JSValue shouldn't protect/unprotect its context
+ https://bugs.webkit.org/show_bug.cgi?id=116234
+
+ Reviewed by Mark Hahnenberg.
+
+ Our retain on _context is sufficient.
+
+ * API/JSValue.mm:
+ (-[JSValue initWithValue:inContext:]):
+ (-[JSValue dealloc]):
+
2013-05-15 Ryosuke Niwa <[email protected]>
Another Windows build fix attempt after r150160.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
