Title: [150212] trunk/Source/WebKit2
Revision
150212
Author
[email protected]
Date
2013-05-16 16:48:49 -0700 (Thu, 16 May 2013)

Log Message

[wk2] didGetImageForFindMatch can return a null image
https://bugs.webkit.org/show_bug.cgi?id=116251
<rdar://problem/13277246>

Reviewed by Simon Fraser.

Don't send didGetImageForFindMatch if we didn't get an image for
the find match, which can happen if the selection is not visible.

* WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::getImageForFindMatch):

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (150211 => 150212)


--- trunk/Source/WebKit2/ChangeLog	2013-05-16 23:38:13 UTC (rev 150211)
+++ trunk/Source/WebKit2/ChangeLog	2013-05-16 23:48:49 UTC (rev 150212)
@@ -31,6 +31,20 @@
 
 2013-05-16  Tim Horton  <[email protected]>
 
+        [wk2] didGetImageForFindMatch can return a null image
+        https://bugs.webkit.org/show_bug.cgi?id=116251
+        <rdar://problem/13277246>
+
+        Reviewed by Simon Fraser.
+
+        Don't send didGetImageForFindMatch if we didn't get an image for
+        the find match, which can happen if the selection is not visible.
+
+        * WebProcess/WebPage/FindController.cpp:
+        (WebKit::FindController::getImageForFindMatch):
+
+2013-05-16  Tim Horton  <[email protected]>
+
         [wk2] Minimum layout width is lost if the WebProcess crashes
         https://bugs.webkit.org/show_bug.cgi?id=116202
         <rdar://problem/13202320>

Modified: trunk/Source/WebKit2/WebProcess/WebPage/FindController.cpp (150211 => 150212)


--- trunk/Source/WebKit2/WebProcess/WebPage/FindController.cpp	2013-05-16 23:38:13 UTC (rev 150211)
+++ trunk/Source/WebKit2/WebProcess/WebPage/FindController.cpp	2013-05-16 23:48:49 UTC (rev 150212)
@@ -251,6 +251,9 @@
 
     frame->selection()->setSelection(oldSelection);
 
+    if (handle.isNull())
+        return;
+
     m_webPage->send(Messages::WebPageProxy::DidGetImageForFindMatch(handle, matchIndex));
 }
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to