Title: [150439] trunk
- Revision
- 150439
- Author
- [email protected]
- Date
- 2013-05-21 06:16:24 -0700 (Tue, 21 May 2013)
Log Message
[GTK][WK2] accessibility/label-for-control-hittest.html is failing
https://bugs.webkit.org/show_bug.cgi?id=106341
Patch by Krzysztof Czech <[email protected]> on 2013-05-21
Reviewed by Martin Robinson.
Tools:
Adds support for retrieving accessibility element at exact point.
* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::elementAtPoint):
LayoutTests:
Fixing failing test. The reason of failure is missing
possibility of getting accessibility object at exact position.
* platform/gtk-wk2/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (150438 => 150439)
--- trunk/LayoutTests/ChangeLog 2013-05-21 13:14:22 UTC (rev 150438)
+++ trunk/LayoutTests/ChangeLog 2013-05-21 13:16:24 UTC (rev 150439)
@@ -1,5 +1,17 @@
2013-05-21 Krzysztof Czech <[email protected]>
+ [GTK][WK2] accessibility/label-for-control-hittest.html is failing
+ https://bugs.webkit.org/show_bug.cgi?id=106341
+
+ Reviewed by Martin Robinson.
+
+ Fixing failing test. The reason of failure is missing
+ possibility of getting accessibility object at exact position.
+
+ * platform/gtk-wk2/TestExpectations:
+
+2013-05-21 Krzysztof Czech <[email protected]>
+
[EFL] accessibility/accessibility-node-reparent.html is failing
https://bugs.webkit.org/show_bug.cgi?id=112026
Modified: trunk/LayoutTests/platform/gtk-wk2/TestExpectations (150438 => 150439)
--- trunk/LayoutTests/platform/gtk-wk2/TestExpectations 2013-05-21 13:14:22 UTC (rev 150438)
+++ trunk/LayoutTests/platform/gtk-wk2/TestExpectations 2013-05-21 13:16:24 UTC (rev 150439)
@@ -303,7 +303,6 @@
webkit.org/b/106337 accessibility/aria-help.html [ Failure ]
webkit.org/b/106338 accessibility/aria-hidden-updates-alldescendants.html [ Failure ]
webkit.org/b/106340 accessibility/img-fallsback-to-title.html [ Failure ]
-webkit.org/b/106341 accessibility/label-for-control-hittest.html [ Failure ]
webkit.org/b/106343 accessibility/loading-iframe-sends-notification.html [ Failure ]
webkit.org/b/106344 accessibility/placeholder.html [ Failure ]
webkit.org/b/106346 accessibility/svg-remote-element.html [ Timeout ]
Modified: trunk/Tools/ChangeLog (150438 => 150439)
--- trunk/Tools/ChangeLog 2013-05-21 13:14:22 UTC (rev 150438)
+++ trunk/Tools/ChangeLog 2013-05-21 13:16:24 UTC (rev 150439)
@@ -1,5 +1,17 @@
2013-05-21 Krzysztof Czech <[email protected]>
+ [GTK][WK2] accessibility/label-for-control-hittest.html is failing
+ https://bugs.webkit.org/show_bug.cgi?id=106341
+
+ Reviewed by Martin Robinson.
+
+ Adds support for retrieving accessibility element at exact point.
+
+ * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
+ (WTR::AccessibilityUIElement::elementAtPoint):
+
+2013-05-21 Krzysztof Czech <[email protected]>
+
[ATK] [WebKit2] AccessibilityUIElement often leaks its AtkObject
https://bugs.webkit.org/show_bug.cgi?id=112913
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp (150438 => 150439)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp 2013-05-21 13:14:22 UTC (rev 150438)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp 2013-05-21 13:16:24 UTC (rev 150439)
@@ -316,8 +316,11 @@
PassRefPtr<AccessibilityUIElement> AccessibilityUIElement::elementAtPoint(int x, int y)
{
- // FIXME: implement
- return 0;
+ if (!m_element || !ATK_IS_OBJECT(m_element.get()))
+ return 0;
+
+ GRefPtr<AtkObject> objectAtPoint = adoptGRef(atk_component_ref_accessible_at_point(ATK_COMPONENT(m_element.get()), x, y, ATK_XY_WINDOW));
+ return objectAtPoint ? AccessibilityUIElement::create(objectAtPoint.get()) : 0;
}
unsigned AccessibilityUIElement::indexOfChild(AccessibilityUIElement* element)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
