Title: [150449] trunk/Source/_javascript_Core
Revision
150449
Author
[email protected]
Date
2013-05-21 09:44:01 -0700 (Tue, 21 May 2013)

Log Message

Added missing assert condition for PositiveOrZero in ARM branch32().
https://bugs.webkit.org/show_bug.cgi?id=116538.

Reviewed by Geoffrey Garen.

* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::branchAdd32):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (150448 => 150449)


--- trunk/Source/_javascript_Core/ChangeLog	2013-05-21 16:39:28 UTC (rev 150448)
+++ trunk/Source/_javascript_Core/ChangeLog	2013-05-21 16:44:01 UTC (rev 150449)
@@ -1,3 +1,13 @@
+2013-05-21  Mark Lam  <[email protected]>
+
+        Added missing assert condition for PositiveOrZero in ARM branch32().
+        https://bugs.webkit.org/show_bug.cgi?id=116538.
+
+        Reviewed by Geoffrey Garen.
+
+        * assembler/MacroAssemblerARM.h:
+        (JSC::MacroAssemblerARM::branchAdd32):
+
 2013-05-20  Mark Hahnenberg  <[email protected]>
 
         Disable SuperRegion

Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h (150448 => 150449)


--- trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h	2013-05-21 16:39:28 UTC (rev 150448)
+++ trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h	2013-05-21 16:44:01 UTC (rev 150449)
@@ -687,35 +687,40 @@
 
     Jump branchAdd32(ResultCondition cond, RegisterID src, RegisterID dest)
     {
-        ASSERT((cond == Overflow) || (cond == Signed) || (cond == Zero) || (cond == NonZero));
+        ASSERT((cond == Overflow) || (cond == Signed) || (cond == Zero)
+            || (cond == NonZero) || (cond == PositiveOrZero));
         add32(src, dest);
         return Jump(m_assembler.jmp(ARMCondition(cond)));
     }
 
     Jump branchAdd32(ResultCondition cond, RegisterID op1, RegisterID op2, RegisterID dest)
     {
-        ASSERT((cond == Overflow) || (cond == Signed) || (cond == Zero) || (cond == NonZero));
+        ASSERT((cond == Overflow) || (cond == Signed) || (cond == Zero)
+            || (cond == NonZero) || (cond == PositiveOrZero));
         add32(op1, op2, dest);
         return Jump(m_assembler.jmp(ARMCondition(cond)));
     }
 
     Jump branchAdd32(ResultCondition cond, TrustedImm32 imm, RegisterID dest)
     {
-        ASSERT((cond == Overflow) || (cond == Signed) || (cond == Zero) || (cond == NonZero));
+        ASSERT((cond == Overflow) || (cond == Signed) || (cond == Zero)
+            || (cond == NonZero) || (cond == PositiveOrZero));
         add32(imm, dest);
         return Jump(m_assembler.jmp(ARMCondition(cond)));
     }
 
     Jump branchAdd32(ResultCondition cond, RegisterID src, TrustedImm32 imm, RegisterID dest)
     {
-        ASSERT((cond == Overflow) || (cond == Signed) || (cond == Zero) || (cond == NonZero));
+        ASSERT((cond == Overflow) || (cond == Signed) || (cond == Zero)
+            || (cond == NonZero) || (cond == PositiveOrZero));
         add32(src, imm, dest);
         return Jump(m_assembler.jmp(ARMCondition(cond)));
     }
 
     Jump branchAdd32(ResultCondition cond, TrustedImm32 imm, AbsoluteAddress dest)
     {
-        ASSERT((cond == Overflow) || (cond == Signed) || (cond == Zero) || (cond == NonZero));
+        ASSERT((cond == Overflow) || (cond == Signed) || (cond == Zero)
+            || (cond == NonZero) || (cond == PositiveOrZero));
         add32(imm, dest);
         return Jump(m_assembler.jmp(ARMCondition(cond)));
     }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to