Title: [150615] trunk/Tools
Revision
150615
Author
[email protected]
Date
2013-05-23 16:00:57 -0700 (Thu, 23 May 2013)

Log Message

Remove meaningless "test_uses_apache" from Python test cases.
https://bugs.webkit.org/show_bug.cgi?id=38756

Patch by Brent Fulgham <[email protected]> on 2013-05-23
Reviewed by Ryosuke Niwa.

* Scripts/webkitpy/port/port_testcase.py:
(PortTestCase.test_driver_cmd_line): Remove the meaningless
"test_uses_apache" test case from the Python test infrastructure.
It was hard-coded to true, even though not all ports use
Apache.

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (150614 => 150615)


--- trunk/Tools/ChangeLog	2013-05-23 21:44:33 UTC (rev 150614)
+++ trunk/Tools/ChangeLog	2013-05-23 23:00:57 UTC (rev 150615)
@@ -1,3 +1,16 @@
+2013-05-23  Brent Fulgham  <[email protected]>
+
+        Remove meaningless "test_uses_apache" from Python test cases.
+        https://bugs.webkit.org/show_bug.cgi?id=38756
+
+        Reviewed by Ryosuke Niwa.
+
+        * Scripts/webkitpy/port/port_testcase.py:
+        (PortTestCase.test_driver_cmd_line): Remove the meaningless
+        "test_uses_apache" test case from the Python test infrastructure.
+        It was hard-coded to true, even though not all ports use
+        Apache.
+
 2013-05-23  Brent Fulgham  <[email protected]>
 
         [Windows] Update new-run-webkit-tests for Windows port.

Modified: trunk/Tools/Scripts/webkitpy/port/port_testcase.py (150614 => 150615)


--- trunk/Tools/Scripts/webkitpy/port/port_testcase.py	2013-05-23 21:44:33 UTC (rev 150614)
+++ trunk/Tools/Scripts/webkitpy/port/port_testcase.py	2013-05-23 23:00:57 UTC (rev 150615)
@@ -115,9 +115,6 @@
         self.assertTrue('--foo=bar' in cmd_line)
         self.assertTrue('--foo=baz' in cmd_line)
 
-    def test_uses_apache(self):
-        self.assertTrue(self.make_port()._uses_apache())
-
     def assert_servers_are_down(self, host, ports):
         for port in ports:
             try:
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to