Title: [150987] trunk/LayoutTests
Revision
150987
Author
[email protected]
Date
2013-05-30 14:31:21 -0700 (Thu, 30 May 2013)

Log Message

fast/dom/location-new-window-no-crash.html times out flakily on mac-wk2
https://bugs.webkit.org/show_bug.cgi?id=117037

Reviewed by Alexey Proskuryakov.

Close the window on a zero-delay timer, working around a bug where WKTR
will hang if a window is closed while a load is in progress.

Doesn't affect the test in an important way.

* fast/dom/script-tests/location-new-window-no-crash.js:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (150986 => 150987)


--- trunk/LayoutTests/ChangeLog	2013-05-30 21:18:14 UTC (rev 150986)
+++ trunk/LayoutTests/ChangeLog	2013-05-30 21:31:21 UTC (rev 150987)
@@ -1,3 +1,17 @@
+2013-05-30  Tim Horton  <[email protected]>
+
+        fast/dom/location-new-window-no-crash.html times out flakily on mac-wk2
+        https://bugs.webkit.org/show_bug.cgi?id=117037
+
+        Reviewed by Alexey Proskuryakov.
+
+        Close the window on a zero-delay timer, working around a bug where WKTR
+        will hang if a window is closed while a load is in progress.
+
+        Doesn't affect the test in an important way.
+
+        * fast/dom/script-tests/location-new-window-no-crash.js:
+
 2013-05-30  Zan Dobersek  <[email protected]>
 
         Update XMLHttpRequest timeout tests to a newer version from W3C

Modified: trunk/LayoutTests/fast/dom/script-tests/location-new-window-no-crash.js (150986 => 150987)


--- trunk/LayoutTests/fast/dom/script-tests/location-new-window-no-crash.js	2013-05-30 21:18:14 UTC (rev 150986)
+++ trunk/LayoutTests/fast/dom/script-tests/location-new-window-no-crash.js	2013-05-30 21:31:21 UTC (rev 150987)
@@ -44,16 +44,18 @@
 shouldBe("testWindow.location.search", "''");
 shouldBe("testWindow.location.hash", "''");
 
-testWindow.close();
+setTimeout(function () {
+    testWindow.close();
 
-if (window.testRunner) {
-    function doneHandler()
-    {
-        if (testWindow.closed) {
-            testRunner.notifyDone();
-            return;
+    if (window.testRunner) {
+        function doneHandler()
+        {
+            if (testWindow.closed) {
+                testRunner.notifyDone();
+                return;
+            }
+            setTimeout(doneHandler, 0);
         }
-        setTimeout(doneHandler, 0);
+        doneHandler();
     }
-    doneHandler();
-}
+}, 0);
\ No newline at end of file
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to