Title: [151233] trunk/Source/WebKit/blackberry
- Revision
- 151233
- Author
- [email protected]
- Date
- 2013-06-05 12:38:55 -0700 (Wed, 05 Jun 2013)
Log Message
[BlackBerry] Selection handles are inverted on directional selections
https://bugs.webkit.org/show_bug.cgi?id=117269
Reviewed by Rob Buis.
PR 336178
Don't invert the handles leave them in the visual order.
Internally Reviewed by Nima Ghanavatian.
* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/ChangeLog (151232 => 151233)
--- trunk/Source/WebKit/blackberry/ChangeLog 2013-06-05 19:18:46 UTC (rev 151232)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2013-06-05 19:38:55 UTC (rev 151233)
@@ -1,3 +1,19 @@
+2013-06-05 Mike Fenton <[email protected]>
+
+ [BlackBerry] Selection handles are inverted on directional selections
+ https://bugs.webkit.org/show_bug.cgi?id=117269
+
+ Reviewed by Rob Buis.
+
+ PR 336178
+
+ Don't invert the handles leave them in the visual order.
+
+ Internally Reviewed by Nima Ghanavatian.
+
+ * WebKitSupport/SelectionHandler.cpp:
+ (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
+
2013-06-03 Andrew Lo <[email protected]>
[BlackBerry] Expose show debug borders setting through BlackBerry::WebKit::WebPage
Modified: trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp (151232 => 151233)
--- trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp 2013-06-05 19:18:46 UTC (rev 151232)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp 2013-06-05 19:38:55 UTC (rev 151233)
@@ -1237,13 +1237,6 @@
}
}
- if (!frame->selection()->selection().isBaseFirst()) {
- // End handle comes before start, invert the caret reference points.
- WebCore::IntRect tmpCaret(startCaret);
- startCaret = endCaret;
- endCaret = tmpCaret;
- }
-
SelectionLog(Platform::LogLevelInfo,
"SelectionHandler::selectionPositionChanged Start Rect=%s End Rect=%s",
Platform::IntRect(startCaret).toString().c_str(),
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
