Title: [151276] trunk/LayoutTests
- Revision
- 151276
- Author
- [email protected]
- Date
- 2013-06-06 09:29:23 -0700 (Thu, 06 Jun 2013)
Log Message
selectionStart/selectionEnd return "obsolete" values when requested during "input" event
https://bugs.webkit.org/show_bug.cgi?id=117287
Reviewed by Darin Adler.
Qt-WK2 test crashes when eventSender.keyDown invocations are nested.
This patch unrolls recursion to avoid crash.
* editing/selection/caret-after-keypress.html:
unroll recursive eventSender.keyDown invocations
* platform/qt-5.0-wk2/TestExpectations: Unskip test.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (151275 => 151276)
--- trunk/LayoutTests/ChangeLog 2013-06-06 16:27:16 UTC (rev 151275)
+++ trunk/LayoutTests/ChangeLog 2013-06-06 16:29:23 UTC (rev 151276)
@@ -1,3 +1,18 @@
+2013-06-06 Eugene Klyuchnikov <[email protected]>
+
+ selectionStart/selectionEnd return "obsolete" values when requested during "input" event
+ https://bugs.webkit.org/show_bug.cgi?id=117287
+
+ Reviewed by Darin Adler.
+
+ Qt-WK2 test crashes when eventSender.keyDown invocations are nested.
+
+ This patch unrolls recursion to avoid crash.
+
+ * editing/selection/caret-after-keypress.html:
+ unroll recursive eventSender.keyDown invocations
+ * platform/qt-5.0-wk2/TestExpectations: Unskip test.
+
2013-06-06 Chris Fleizach <[email protected]>
AX: iOS ignores ARIA progressbar elements
Modified: trunk/LayoutTests/editing/selection/caret-after-keypress.html (151275 => 151276)
--- trunk/LayoutTests/editing/selection/caret-after-keypress.html 2013-06-06 16:27:16 UTC (rev 151275)
+++ trunk/LayoutTests/editing/selection/caret-after-keypress.html 2013-06-06 16:29:23 UTC (rev 151276)
@@ -13,17 +13,18 @@
var input = ["a", "b", "c", backSpace, backSpace, backSpace];
var output = ["", "a", "ab", "abc", "ab", "a", ""];
-function step() {
+function dumpState() {
var expectedValue = output.shift();
shouldBeEqualToString("test.value", expectedValue);
shouldBe("test.selectionStart", "" + expectedValue.length);
shouldBe("test.selectionEnd", "" + expectedValue.length);
debug("");
- eventSender.keyDown(input.shift());
}
-test.addEventListener("input", step);
-step();
+test.addEventListener("input", dumpState);
+dumpState();
+while (input.length)
+ eventSender.keyDown(input.shift());
</script>
<script src=""
</body>
Modified: trunk/LayoutTests/platform/qt-5.0-wk2/TestExpectations (151275 => 151276)
--- trunk/LayoutTests/platform/qt-5.0-wk2/TestExpectations 2013-06-06 16:27:16 UTC (rev 151275)
+++ trunk/LayoutTests/platform/qt-5.0-wk2/TestExpectations 2013-06-06 16:29:23 UTC (rev 151276)
@@ -39,7 +39,6 @@
editing/selection/doubleclick-whitespace-crash.html
editing/selection/doubleclick-whitespace-img-crash.html
editing/selection/doubleclick-whitespace.html
-editing/selection/caret-after-keypress.html
editing/selection/empty-cell-right-click.html
editing/selection/move-begin-end.html
editing/selection/select-out-of-editable.html
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
