Title: [151324] trunk/Source/WebKit2
- Revision
- 151324
- Author
- [email protected]
- Date
- 2013-06-07 09:37:32 -0700 (Fri, 07 Jun 2013)
Log Message
[GTK] Weird behaviour and no clues to the user when the shared memory file can't be opened
https://bugs.webkit.org/show_bug.cgi?id=117063
Patch by Enrique Ocana Gonzalez <[email protected]> on 2013-06-07
Reviewed by Anders Carlsson.
Log error message when the shared memory file can't be opened in
Unix platform using a release build
* Platform/unix/SharedMemoryUnix.cpp:
(WebKit::SharedMemory::create):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (151323 => 151324)
--- trunk/Source/WebKit2/ChangeLog 2013-06-07 15:57:17 UTC (rev 151323)
+++ trunk/Source/WebKit2/ChangeLog 2013-06-07 16:37:32 UTC (rev 151324)
@@ -1,3 +1,16 @@
+2013-06-07 Enrique Ocana Gonzalez <[email protected]>
+
+ [GTK] Weird behaviour and no clues to the user when the shared memory file can't be opened
+ https://bugs.webkit.org/show_bug.cgi?id=117063
+
+ Reviewed by Anders Carlsson.
+
+ Log error message when the shared memory file can't be opened in
+ Unix platform using a release build
+
+ * Platform/unix/SharedMemoryUnix.cpp:
+ (WebKit::SharedMemory::create):
+
2013-06-07 Grzegorz Czajkowski <[email protected]>
[EFL][WK2] Context menu spellchecking items are not available when "Check Spelling While Typing" is off
Modified: trunk/Source/WebKit2/Platform/unix/SharedMemoryUnix.cpp (151323 => 151324)
--- trunk/Source/WebKit2/Platform/unix/SharedMemoryUnix.cpp 2013-06-07 15:57:17 UTC (rev 151323)
+++ trunk/Source/WebKit2/Platform/unix/SharedMemoryUnix.cpp 2013-06-07 16:37:32 UTC (rev 151324)
@@ -109,8 +109,10 @@
fileDescriptor = shm_open(tempName.data(), O_CREAT | O_CLOEXEC | O_RDWR, S_IRUSR | S_IWUSR);
} while (fileDescriptor == -1 && errno == EINTR);
}
- if (fileDescriptor == -1)
+ if (fileDescriptor == -1) {
+ WTFLogAlways("Failed to create shared memory file %s", tempName.data());
return 0;
+ }
while (ftruncate(fileDescriptor, size) == -1) {
if (errno != EINTR) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
