Title: [151347] branches/dfgFourthTier/Source/_javascript_Core
- Revision
- 151347
- Author
- [email protected]
- Date
- 2013-06-08 13:36:44 -0700 (Sat, 08 Jun 2013)
Log Message
Removed bogus assertion in CallFrame::setLocationAsBytecodeOffset().
https://bugs.webkit.org/show_bug.cgi?id=117373.
Reviewed by Oliver Hunt.
The assertion wrongly assumes that the incoming offset argument is in
units of bytes. This is not true. It is in units of Instruction*. Hence,
the assertion which checks for the low 2 bits to be clear can fail.
* interpreter/CallFrame.cpp:
(JSC::CallFrame::setLocationAsBytecodeOffset):
Modified Paths
Diff
Modified: branches/dfgFourthTier/Source/_javascript_Core/ChangeLog (151346 => 151347)
--- branches/dfgFourthTier/Source/_javascript_Core/ChangeLog 2013-06-08 11:34:25 UTC (rev 151346)
+++ branches/dfgFourthTier/Source/_javascript_Core/ChangeLog 2013-06-08 20:36:44 UTC (rev 151347)
@@ -1,3 +1,17 @@
+2013-06-08 Mark Lam <[email protected]>
+
+ Removed bogus assertion in CallFrame::setLocationAsBytecodeOffset().
+ https://bugs.webkit.org/show_bug.cgi?id=117373.
+
+ Reviewed by Oliver Hunt.
+
+ The assertion wrongly assumes that the incoming offset argument is in
+ units of bytes. This is not true. It is in units of Instruction*. Hence,
+ the assertion which checks for the low 2 bits to be clear can fail.
+
+ * interpreter/CallFrame.cpp:
+ (JSC::CallFrame::setLocationAsBytecodeOffset):
+
2013-06-07 Filip Pizlo <[email protected]>
Unreviewed, roll out http://trac.webkit.org/changeset/151342
Modified: branches/dfgFourthTier/Source/_javascript_Core/interpreter/CallFrame.cpp (151346 => 151347)
--- branches/dfgFourthTier/Source/_javascript_Core/interpreter/CallFrame.cpp 2013-06-08 11:34:25 UTC (rev 151346)
+++ branches/dfgFourthTier/Source/_javascript_Core/interpreter/CallFrame.cpp 2013-06-08 20:36:44 UTC (rev 151347)
@@ -52,7 +52,6 @@
void CallFrame::setLocationAsBytecodeOffset(unsigned offset)
{
ASSERT(codeBlock());
- ASSERT(Location::isBytecodeLocation(offset));
setCurrentVPC(codeBlock()->instructions().begin() + offset);
ASSERT(hasLocationAsBytecodeOffset());
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
